🚀 go-pugleaf

"Alfred" <alf@no.spam.not.valid.email> wrote in message
news:4383d048$1@newsgroups.borland.com...

> void __fastcall TForm1::FormCreate(TObject *Sender)

Do not use the OnCreate event in C++.  It is a Delphi idiom that can produce
illegal behavior in C++ as it can be executed before the constructor.  Use
the actual constructor instead.

>           Form1->Close();

You cannot use Close() while the form is still creating itself.  If you want
the application is end, then use the Application->Terminate() method
instead.

> bool __fastcall TForm1::ExecuteFile(String FileName)

You should always pass strings by const reference.

>         AnsiString Path = ExtractFilePath( ParamStr(0) ) + "\\" +
FileName;

ExtractFilePath() includes the trailing backslash, so you are effectly
formatting an invalid path by adding your own backslash in front of the
filename.

>         int rc = (int) ShellExecute( Application->Handle, "open",
Path.c_str(), NULL, NULL, SW_SHOWDEFAULT ) ;

WinExec() or CreateProcess() would be better to use for executable files.
ShellExecute() is designed primarily for documents and such.

With that said, try this code instead:


    __fastcall TForm1::TForm1(TComponent *Owner)
    {
        if( ExecuteFile("Downloader.exe") )
        {
            Application->ShowMainForm = false;
            Application->Terminate();
        }
    }

    bool __fastcall TForm1::ExecuteFile(const AnsiString &FileName)
    {
        AnsiString Path = ExtractFilePath(Application->ExeName) + FileName;

        STARTUPINFO si = {sizeof(STARTUPINFO), 0};
        PROCESS_INFORMATION pi = {0};

        if( CreateProcess(NULL, Path.c_str(), NULL, NULL, FALSE, 0, NULL,
NULL, &si, &pi) )
        {
            CloseHandle(pi.hThread);
            CloseHandle(pi.hProcess);
            return true;
        }

        MemoNews->Lines->Add("Errore di autoaggiornamento numero : " +
AnsiString(GetLastError()));
        return false;
    }


A better approach would be to not even create the TForm at all unless you
are actually going to use it.  You can do that moving the code into the
WinMain() function for the project, ie:

    #include "Unit1.h"

    bool __fastcall ExecuteFile(const AnsiString &FileName)
    {
        AnsiString Path = ExtractFilePath(Application->ExeName) + FileName;

        STARTUPINFO si = {sizeof(STARTUPINFO), 0};
        PROCESS_INFORMATION pi = {0};

        if( CreateProcess(NULL, Path.c_str(), NULL, NULL, FALSE, 0, NULL,
NULL, &si, &pi) )
        {
            CloseHandle(pi.hThread);
            CloseHandle(pi.hProcess);
            return true;
        }

        return false;
    }

    int WINAPI WinMain(HINSTANCE, HINSTANCE, LPSTR, int)
    {
        if( !ExecuteFile("Downloader.exe") )
        {
            AnsiString s = "Errore di autoaggiornamento numero : " +
AnsiString(GetLastError());
            try
            {
                Application->Initialize();
                Application->CreateForm(__classid(TForm1), &Form1);
                Form1->MemoNews->Lines->Add(s);
                Application->Run();
            }
            catch(Exception &exception)
            {
                Application::ShowException(&exception);
            }
        }
        return 0;
    }


Gambit