🚀 go-pugleaf

Martin Nijhoff wrote:

>Some time ago I wrote a serial port component using overlapped I/O. The
>component creates a thread to monitor the serial port an trigger some event
>handlers.
>
>The component works fine on both Win98 and WinXP, that is, most of the time.
>Sometimes an error occurs while writing to the serial port, in which case
>the WriteFile() fails and GetLastError() returns ERROR_OPERATION_ABORTED
>(995).

You removed some code. Did any of that code contain CancelIO() ?

You didn't show osRead or osWrite.

Your class has One OVERLAPPED struct, not 2, and you wait on 2 events.
I would think you would want to wait on 3 events, evRead, evWrite and
evTerminate

You are blocking after read and write, so why are you using overlapped
instead of blocking i/o?

You aren't handling any errors from ReadFile() or WriteFile().

>DWORD __fastcall TCustomCOMPort::Write (void *Buffer, DWORD Size)
>{
>  DWORD BytesWritten;
>
>  if (FHandle == INVALID_HANDLE_VALUE)
>    throw Exception(SPortClosed);
>
>  if (!WriteFile(FHandle, Buffer, Size, &BytesWritten, &osWrite))
>  {
>    if (GetLastError() == ERROR_IO_PENDING)
>      WaitForAsync(osWrite, BytesWritten);
>  }
>  return(BytesWritten);
>}