🚀 go-pugleaf

Neil P. wrote:

> do
>  {
>   clComm.Read(1);
>   cResponse = NULL;

	Why the double assign?

>   cResponse = clComm.cTransBuff;

>    // Clear the buffers
>    for (int i = 0; i <= (BUFSIZE - 1); i++)
>     bCommData[i] = NULL;

    // Clearer Clear the buffers
	memset( bCommData, 0, sizeof(bCommData)  );

>    // Set a safety timeout
>    dwRead_Time_Out = GetTickCount() + (iExpected*2);

The first data won't arrive for .001042 seconds, so you are leaving
only .000958 seconds for the device to get the character you sent and
respond. Also, realise that the counter isn't all that accurate to
begin with.  Example: First call is at 1.001999 and shows 1.001, that
leaves you with less than 1 character-time before you time out.

To be fair to the device, you would need to allow 1.042 msec per
character sent, plus reasonable processing time, plus the same amount
times chars to receive. Also, some devices don't send at full baud
rate. I've see 50% duty cycles on some devices (one full char-time
between chars).

>    while (bStop_Read == false)
>     {
>       // Clear any communication error & return # of bytes in the input
>buffer
>       ClearCommError(hComm, &dwError, &comstat);

See other message.

>             GetOverlappedResult(hComm,
>                                 &o,
>                                 &dwActualBytesRead,
>                                 FALSE);
>
>             // Are there bytes waiting and check if buffer is not overrun
>             if ((dwActualBytesRead != 0) && (dwActualBytesRead <= BUFSIZE))

  Not right. Can overflow cTransBuf. Also discards data and perhaps
causes timeout because you threw away the data you were waiting for.

>              { // Begin if statement (actual bytes read)
>
>                // Start the collection of bytes
>                for (unsigned int i = 0; i <= (dwActualBytesRead - 1); i++)
>                 { // Begin for statement (byte collect)
>
>                   // Copy the data to the return variable
>                   cTransBuff[iCollectBytes++] = bCommData[i];
>