🚀 go-pugleaf

Thanks,

I'll implement all that tomorrow...


-- 
Best regards,
Vladimir Stefanovic
"Remy Lebeau (TeamB)" <no.spam@no.spam.com> wrote in message 
news:42791382$1@newsgroups.borland.com...
>
> "Vladimir Stefanovic" <antivari@po.sbb.co.yu> wrote in message
> news:4278b3f0@newsgroups.borland.com...
>
>> Anyway, can you please take a short look at the code and see if
>> I should make any (maybe code security) corrections to it.
>
>> 1) Is there any sigifficant difference if I use SendMessage() or
>> PostMessage() from my DLL, in my case?
>
> That entirely depends on your actual needs.  SendMessage() waits for the
> message to be processed.  PostMessage() does not.
>
>> 2) In the API CreateFileMapping(), I named a last argument
>> "DiHook", and I never used it after that. Is that OK? Should I use
>> NULL?
>
> No, do not use NULL, or else the memory won't be shared at all.  The name 
> is
> what makes it sharable to begin with.
>
>> 3) Is that normal that I haven't any chages (because of shared memory
>> changes in y DLL) at my App side, except that I passed the HWND
>> argument to install a DLL?
>
>
>> extern "C" __declspec(dllexport) __stdcall void SetHook(HWND);
>> extern "C" __declspec(dllexport) __stdcall void RemoveHook(void);
>
> I would recommend adding return values to those functions so that the
> application can know whether or not the hooking/unhooking actuall 
> succeeds.
>
>>            if ( hFileMapping )
>>               pHookInfo = (PHOOKINFO)MapViewOfFile( hFileMapping,
>>                                                     FILE_MAP_WRITE,
>>                                                     0,
>>                                                     0,
>>                                                     0 );
>
> If either CreateFileMapping() or MapViewOfFile() fail, I prefer to release
> the file mapping and make DllEntryPoint() return FALSE.  That way, the
> application knows that the DLL was unable to initialize itself, and thus 
> the
> hooks won't work properly.
>
>>            UnmapViewOfFile( pHookInfo );
>>            pHookInfo = NULL;
>>            CloseHandle( hFileMapping );
>>            hFileMapping = NULL;
>>            break;
>
> Make sure to check for NULL pointers before calling the functions:
>
>    if( pHookInfo  )
>        UnmapViewOfFile( pHookInfo );
>    if( hFileMapping )
>        CloseHandle( hFileMapping );
>
>> DWORD __stdcall CheckKey( int nCode, WORD wParam, LONG lParam )
>
> You can simplify that code to the following:
>
>    DWORD __stdcall CheckKey( int nCode, WORD wParam, LONG lParam )
>    {
>        if( pHookInfo )
>        {
>            if( ((nCode >= 0) && (nCode != HC_NOREMOVE))
>                && ((lParam & 0x40000000) == 0) // Skip if it's a repeat
>                && (lParam & 0x20000000) ) // Check if Alt is pressed
>            {
>                // Send key information to the main window
>                if( pHookInfo->hAppWnd )
>                    PostMessage(pHookInfo->hAppWnd, WM_KEYHOOK, 0, lParam);
>            }
>            return CallNextHookEx(pHookInfo->ghhookKB, nCode, wParam,
> lParam);
>        }
>        return 0;
>    }
>
>
> Gambit
>
>