🚀 go-pugleaf

Wim Bekker wrote:

>I will post my project (40KB) in attachments with some more comment.

I can't promise this is a problem, but I have to wonder about it....

>int __fastcall GetBits(Graphics::TBitmap* Bitmap, void* Buffer, int& Size)
>{
>  unsigned int InfoHeaderSize;
>  unsigned int ImageSize;

>  GetDIBSizes(Bitmap->Handle,InfoHeaderSize,ImageSize);
>  if ((unsigned int)Size<ImageSize)
>  {
>    Size=ImageSize;
>    return -1;
>  }

What if ImageSize is 0?
Then you'll be doing GetDIB into a NULL Buffer.
It is also a wasted call the second time around.
Would be better to make this two functions: GetSize, and GetData, or
incorporate the Buffer allocation into this function, so it only gets
called once.

>  TBitmapInfo BitmapInfo;
>  int Result=GetDIB(Bitmap->Handle,Bitmap->Palette,&BitmapInfo,Buffer);

This fills in BitmapInfo, and Buffer.
 GetDIBSizes() gave you the sizes for both of them, but you only used
the size for Buffer.
It would seem odd that it would give you a size for Info if it was a
set amount. Might be a good idea to allocate the proper size.

>  return Result;
>}

>  //allocate memory
>  if (cxGlobalMemory->Checked)  Buffer=(char*)GlobalAlloc(GMEM_FIXED,Size);
>  else                          Buffer=new char[Size];

You never check if new or GlobalAlloc succeed in allocating Buffer.