🚀 go-pugleaf

Mike Collins wrote:

> Hay all, just a quicky, just wondering if anyone had any thoughts on
> using try... __finally to ensure that a critical section is always
> released?
> 
> I have a thread with a getter and setter to provide access to a
> private variable.  I use a CRITICAL_SECTION to ensure thead-safety
> but i wasn't sure about whether or not to use a try.. __finally to
> ensure that the CS always gets released...

Yes, you can write:

int MyClassGetProp(void)
{
 int res;
 EnterCtiticalSection(&CS);
 try
 {
  /*some code with possible exception*/
  ...
  res=/*some result*/;
 }
 __finally
 {
  LeaveCriticalSection(&CS); // will be executed in any case
 }
 return res;
}

Due to some problems in compiler you should
1) avoid direct ("goto") or indirect ("return") leaving try section.
'Return' is not prohibited but generates a lot of binary code
(intermediate variable for result is much better);
2) don't throw exceptions in __finally section (in theory it should
generate abort but it doesn't);
3) avoid complicated exception handling in __finally (see QC30802)
4) NEVER use 'goto' or 'return' for leaving __finally section.
5) use CB2007 where some problems were fixed (like QC21708)

-- 
Alex

P.S. Please, don't beat me for the post: I know that try/__finally
isn't pure cpp way :-)