🚀 go-pugleaf

"Mortz" <rmorteo@hotmail.com> wrote in message
news:40bcf046@newsgroups.borland.com...

>      hInstance=LoadLibrary("SHELL32.DLL");

Use GetModuleHandle() instead.  All processes have Shell32.dll linked into
them automatically at program startup.  There is no need to re-load the DLL
again since it is already loaded by the time your application's code begin
running.

>
SHObjectProperties=(pSHObjectProperties)GetProcAddress(hInstance,(char
> *)178);

You are not checking to make sure that GetProcAddress() returns a non-NULL
pointer before calling SHObjectProperties().

>      SHObjectProperties(hwnd,OPF_PATHNAME,(wchar_t *)file.c_str(),NULL);
> //perhaps the proble is the casting?

Yes, the casting is problematic.  You cannot cast a char* to a wchar_t*, you
have to actually convert the data from one format to another.  The easiest
way to do that is to use the WideString class, which will do the necessary
conversion internally for you.

>      return true;

You should return the actual result of SHObjectProperties().

Try this code instead:

    #ifndef SHOP_FILEPATH
    #define SHOP_FILEPATH 0x00000002
    #endif

    bool DisplayFileProperties(HWND hwnd, const AnsiString &file)
    {
        pSHObjectProperties lpSHObjectProperties = (pSHObjectProperties)
GetProcAddress(GetModuleHandle("SHELL32"), MAKEINTRESOURCE(178));
        if( lpSHObjectProperties )
        {
            if( lpSHObjectProperties(hwnd, SHOP_FILEPATH, WideString(file),
NULL) )
                return true;
        }
        return ( ((int)ShellExecute(hwnd, "properties", file.c_str(), 0, 0,
SW_SHOWNORMAL)) > 32 );
    }


Gambit