🚀 go-pugleaf

Hi David,

thank you for these valuable sugestions. That all will help to make my 
program better and clearer.

But still, what's about my question?
When I write I get an exception:
Unable to write to D:\SpeedraTel\PROGRAMME\SpeedraTest.ini at 0x0

This procedure TestINI() is just to find out when the problem in the 
program occurs. Then it starts the program new. But that's not a real 
solution.

You have any idea why I get an exception? What can be the reason?

Thank you
Lothar


David Scheffel schrieb:

>Hi Lothar,
>
>I don't feel like your application is well designed right now. There are a 
>lot of things that should be improved basically. E.g. the following:
>
>1.) don't use static char arrays, use AnsiString instead
>2.) since sprintf is unable to throw exceptions you should use Format 
>instead
>3.) you don't need to check if pIniFile is null after you have constructed 
>it! pIniFile is NOT an handle to an IniFile!! It is an pointer that points 
>to an instance of TIniFile. If the ctor of TIniFile runs into an error it'll 
>throw an Exception anyway
>4.) avoid the use of timers unless it's really necessary. You should read 
>the settings when the application is constructed. If you have only a single 
>form or MDI Main Form you could read the settings the the ctor of the form
>
>Further more I'd recommend you to read at least one of these books: "Borland 
>C++Builder 4 Unleashed", "C++Builder 6 Developer's Guide". If you're still 
>unhappy with TIniFile you might have o look at TMemIniFile which works 
>independant from windows and is much faster since it hold the data in the 
>memory.
>
>regards
>//David
>
>  
>
>>void CPtimer::TestINI()
>>{
>>  TIniFile *pIniFile;
>>  char  DisplayStr[200];
>>
>>  if (!TestINIok) return;
>>try {
>>  try {
>>     pIniFile = new 
>>TIniFile(ExtractFilePath(ParamStr(0))+"SpeedraTest.ini");
>>     if (pIniFile) {
>>       pIniFile->WriteDateTime("Test",TestINIstart, Now());
>>       sprintf(DisplayStr,"TestINI ok %d",pIniFile);
>>       Display(DisplayKanalx,DisplayStr);
>>     } else {
>>       DisplaySystemError(DisplayKanalx,"TestINI Fehler");
>>       TestINIok=false;
>>       Form1->EndeundNeustartwennohneAnruf->Checked= true;   // new start 
>>of program
>>     }
>>  } catch(const Exception& e) {
>>       DisplaySystemError(DisplayKanalx,"Exception TestINI");
>>       sprintf(DisplayStr,"!!!Exception: %s at 
>>0x%X",NoSteuer(e.Message).c_str(),ExceptAddr());
>>       Display(DisplayKanalx,DisplayStr);
>>       TestINIok=false;
>>       Form1->EndeundNeustartwennohneAnruf->Checked= true;   // new start 
>>of program
>>  }
>>
>>  delete pIniFile;
>>} catch(const Exception& e) {
>>}
>>}
>>
>>
>>David Scheffel schrieb:
>>
>>    
>>
>>>Could you post the source code?
>>>
>>>
>>>      
>>>
>
>
>  
>