🚀 go-pugleaf

"Safari" <Safari@alloymail.com> wrote in message
news:3E8F1D05.40008@alloymail.com...

> How can i split a file with TFileStream?
> I want to read Exmp:
> 1..50,000 bytes of 1,000,000 bytes to MyFile.001
> 50,001..100,000 bytes of 1,000,000 bytes to MyFile.002

Simply read the file in a loop, each iteration of the loop reading a block
of data and processing it as needed, continuing until the loop has read the
entire stream in full.  For example:

    int iSourceFile = FileOpen("C:\\somefile.ext", fmOpenRead |
fmShareDenyWrite);
    if( iSourceFile == -1 )
    {
        BYTE buffer[50000];
        int iNum = 1;

        do
        {
            int iRead = FileRead(iSourceFile, buffer, 50000);
            if( iRead != -1 )
            {
                if( iRead == 0 )
                    break;    // finished

                AnsiString ext = Format("%.3d", ARRAYOFCONST(( iNum++ )));

                int iNewFile = FileCreate("c:\\MyFile." + ext);
                if( iNewFile != -1 )
                {
                    if( FileWrite(iNewFile, buffer, iRead) != iRead )
                        // an error occured, handle it as needed

                    FileClose(iNewFile);
                }
                else
                    // an error occured, handle it as needed
            }
            else
                // an error occured, handle it as needed
        }
        while( true );
        FileClose(iSourceFile);
    }
    else
        // an error occured, handle it as needed


Gambit

Hello Remy,
I wrote this code before your answer,
return me "Stream File Error..."
Where is my mistake?

Thanks,
Safari

void __fastcall TMain::BitBtn1Click(TObject *Sender)
{
    int b = 0;
    int hExten = 0;
    BYTE hBufer[1];
    int hBytes = Edit3->Text.ToInt();
    if (FileExists(Edit1->Text))
    {
       TFileStream *hSource = new TFileStream(Edit1->Text,
       fmOpenRead | fmShareDenyWrite);
       Progress->Max = hSource->Size;
       for (int a = 0; a < hSource->Size; a++)
       {
          AnsiString hName = Format("%s.%.3d", ARRAYOFCONST((
          Edit2->Text, hExten++)));
          TFileStream *hTarget = new TFileStream(hName, fmCreate);
          do
          {
             b += 1;
             Progress->Position = hSource->Position;
             hSource->ReadBuffer (hBufer, 1);
             hTarget->WriteBuffer(hBufer, 1);
          }
          while ((b = hBytes) | (b > hSource->Size));
          delete hTarget;
       }
       delete hSource;
       Progress->Position = 0;
    }
}


Remy Lebeau (TeamB) wrote:
> "Safari" <Safari@alloymail.com> wrote in message
> news:3E8F1D05.40008@alloymail.com...
> 
> 
>>How can i split a file with TFileStream?
>>I want to read Exmp:
>>1..50,000 bytes of 1,000,000 bytes to MyFile.001
>>50,001..100,000 bytes of 1,000,000 bytes to MyFile.002

"Safari" <Safari@alloymail.com> wrote in message
news:3E91A68B.8000503@alloymail.com...

> I wrote this code before your answer,
> return me "Stream File Error..."
> Where is my mistake?

You didn't indicate where in the code the error is actually coming from, or
what the full error message was.  Please always be more specific when
reporting errors.  However, there are a few problems with your code that is
preventing it from working correctly.

>     BYTE hBufer[1];

This is not a problem, just a comment - you don't need a 1-element array for
that:

    BYTE hBufer;
    ...
    hSource->ReadBuffer(&hBufer, 1);
    hTarget->WriteBuffer(&hBufer, 1);

>           while ((b = hBytes) | (b > hSource->Size));

You're using the wrong operator in there.  You should be using ||, not |.

Why are you comparing the sizes like that?  I think you have your loop
comparisons mixed up.  I looks like you're assuming that the loop will
continue until one of those conditions becomes 'true', while is not the
actual case.  Are you coming from a VB background, by chance?  Your
comparisons should be more like this instead:

    while ((b != hBytes) && (b < hSource->Size));

I'm assuming hBytes is the number of bytes you want each split chunk file to
be?  Why are you splitting the file one byte at a time instead of in larger
chunks to begin with?  You're going to cause a lot of unnecessary overhead
with file I/O doing it that way.

Was there some problem preventing you from using the code I gave you
earlier?


Gambit

Hello Remy,
1. I fail to write or complete this code! return me two errors.
    {a. Stream read error.
    {b. File1: MyFile.001, File2: MyFile.003, File3: MyFile.005 and ...
2. Your simple code dosn't write any file!, excuse me.

Thanks a lot,
Safari

Remy Lebeau (TeamB) wrote:
> Simply read the file in a loop, each iteration of the loop reading a block
> of data and processing it as needed, continuing until the loop has read the
> entire stream in full.  For example:
> 
>     int iSourceFile = FileOpen("C:\\somefile.ext", fmOpenRead |
> fmShareDenyWrite);
>     if( iSourceFile == -1 )
>     {
>         BYTE buffer[50000];
>         int iNum = 1;
> 
>         do
>         {
>             int iRead = FileRead(iSourceFile, buffer, 50000);
>             if( iRead != -1 )
>             {
>                 if( iRead == 0 )
>                     break;    // finished
> 
>                 AnsiString ext = Format("%.3d", ARRAYOFCONST(( iNum++ )));
> 
>                 int iNewFile = FileCreate("c:\\MyFile." + ext);
>                 if( iNewFile != -1 )
>                 {
>                     if( FileWrite(iNewFile, buffer, iRead) != iRead )
>                         // an error occured, handle it as needed
> 
>                     FileClose(iNewFile);
>                 }
>                 else
>                     // an error occured, handle it as needed
>             }
>             else
>                 // an error occured, handle it as needed
>         }
>         while( true );
>         FileClose(iSourceFile);
>     }
>     else
>         // an error occured, handle it as needed
> 
> Gambit

"Safari" <Safari@alloymail.com> wrote in message
news:3E9466BC.8060508@alloymail.com...

> 1. I fail to write or complete this code! return me two errors.
>     {a. Stream read error.

The only time that can happen is inside TStream::ReadBuffer() when
TStream::Read() returns a value other than the requested amount.  Which
makes sense if you are requesting 50000 bytes and it reads fewer (due to end
of file, for example).

The same applies to WriteBuffer() as well - it will throw an exception if
the amount written does not match the amount requested.

You should be calling Read() and Write() instead of ReadBuffer() and
WriteBuffer().

> 2. Your simple code dosn't write any file!, excuse me.

The following code works fine for me:

    int iSourceFile = FileOpen("C:\\test.rtf", fmOpenRead |
fmShareDenyWrite);
    if( iSourceFile != -1 )
    {
        BYTE buffer[50000];
        int iNum = 1;

        do
        {
            int iRead = FileRead(iSourceFile, buffer, 50000);
            if( iRead != -1 )
            {
                if( iRead == 0 )
                    break;    // finished

                AnsiString ext = Format("%.3d", ARRAYOFCONST(( iNum )));
                ++iNum;

                int iNewFile = FileCreate("C:\\test." + ext);
                if( iNewFile != -1 )
                {
                    if( FileWrite(iNewFile, buffer, iRead) != iRead )
                        // an error occured, handle it as needed

                    FileClose(iNewFile);
                }
                else
                    // an error occured, handle it as needed
            }
            else
                // an error occured, handle it as needed
        }
        while( true );
        FileClose(iSourceFile);
    }
    else
        // an error occured, handle it as needed


Gambit

Very tanaks Remy,
I used your source and worked fine.
1. How can i choose size file with your source now?
2. My source return me: Stream read error! why?

void __fastcall TMain::BitBtn1Click(TObject *Sender)
{
     BYTE hBuf;
     int hBin = 0;
     int hExt = 0;
     int hLen = Edit3->Text.ToInt();
     if (FileExists(Edit1->Text))
     {
        TFileStream *hSource = new TFileStream(Edit1->Text, fmOpenRead |
        fmShareDenyWrite);
        Progress->Max = hSource->Size;
        for (int a = 0; a < hSource->Size; a++)
        {
           hExt++;
           AnsiString hName = Format("%s.%.3d",
           ARRAYOFCONST((Edit2->Text, hExt));
           hExt));
           TFileStream *hTarget = new TFileStream(hName, fmCreate);
           do
           {
              hBin++;
              hSource->ReadBuffer (&hBuf, 1);
              hTarget->WriteBuffer(&hBuf, 1);
              Progress->Position = hSource->Position;
           }
           while (hBin != hLen);
           delete hTarget;
        }
        delete hSource;
        Progress->Position = 0;
     }
}

Thanks again,
Safari

"Safari" <Safari@alloymail.com> wrote in message
news:3E955473.6000807@alloymail.com...

> I used your source

No, you're not.  I've posted my code twice for you now, but your code, as
you've posted it here, still does not resemble my code at all.  You're off
doing your own things.  My code does not use TFileStream and sets aside a
fixed-sized buffer and then read/wrote the files in full 50000b blocks at a
time.  Your code, on the other hand, is using TFileStream and is
reading/writing the files one byte at a time instead.

> 1. How can i choose size file with your source now?

Your code, as you've posted it here, is already taking that into account.
Although, your outer for() loop is very very wrong, you're not managing the
loop counter correctly at all.  If you're going to continuing using your own
code instead of mine, then you need to use a while() loop instead of a for()
loop, ie:

    void __fastcall TMain::BitBtn1Click(TObject *Sender)
    {
        ...
        // this loop is wrong!
        // for (int a = 0; a < hSource->Size; a++)

        while( hSource->Position < hSource->Size )
        {
            ...
        }
    }

> 2. My source return me: Stream read error! why?

If you had actually read my other replies, I've already explained to you
exactly why that is occuring.  Do not call ReadBuffer() and WriteBuffer(),
use Read() and Write() instead.  You're getting an exception because you are
using methods that are specifically designed to throw an exception.


Gambit

Hi Remy

  In article <3e9619fe$1@newsgroups.borland.com>,  "Remy Lebeau \(TeamB\)" 
<gambit47@yahoo.com> says :

> 
> "Safari" <Safari@alloymail.com> wrote in message
> news:3E955473.6000807@alloymail.com...
> 
> > I used your source
> 
> No, you're not. 

As i read his answer i think he is using Your code and 
then he post his own code to get an answer to his last 
question..;-)
But You already gave him that so.....

Best regards
Asger

"Asger J�rgensen" <Asger.Pnotthis@AJ-World.dk> wrote in message
news:MPG.19007419b0bed1e79896d2@newsgroups.borland.com...

> As i read his answer i think he is using Your code and
> then he post his own code to get an answer to his last
> question..;-)

He should always be posting the code he's actually using, not using one code
and then posting with a completely different one.


Gambit

As well as Remy's comment about using the wrong operator in the or '|'
instead of '||' I believe you are also using the wrong comparison operator,
you have b = hBytes, which means that you are setting b to be hBytes,
whereas I think you mean b == hBytes, which means, 'does b equate to
hBytes?'

Phil

"Remy Lebeau (TeamB)" <gambit47@yahoo.com> wrote in message
news:3e91b462$1@newsgroups.borland.com...
>
> "Safari" <Safari@alloymail.com> wrote in message
> news:3E91A68B.8000503@alloymail.com...
>
<SNIP>
> >           while ((b = hBytes) | (b > hSource->Size));
>
> You're using the wrong operator in there.  You should be using ||, not |.

Hello again Remy,
I say my source return error, not your source.
My source here is:

Procedure TMain.BitBtn3Click(Sender: TObject);
Var hSource, hTarget: TFileStream; hChoose: String;
     hBuf: Byte; hBin, hExt, hInt: Integer; hLen: Longint;
Begin
    hBin := 0;
    hExt := 0;
    hLen := StrToInt(Edit3.Text);
    hSource := TFileStream.Create(Edit1.Text, fmOpenRead
    or fmShareDenyWrite);
    Progress.Max := hSource.Size;
    for hInt := 0 to hSource.Size - 1 do
    Begin
       Inc(hExt);
       hChoose := Format('%s.%.3d', [Edit2.Text, hExt]);
       hTarget := TFileStream.Create(hChoose, fmCreate);
       Repeat
          Inc(hBin);
          hSource.ReadBuffer (hBuf, 1);
          hTarget.WriteBuffer(hBuf, 1);
          Progress.Position := hSource.Size;
       Until hBin = hLen;
       hTarget.Free;
    End;
    hSource.Free;
    Progress.Position := 0;
End;
-------------------------------------------------------------------------
void __fastcall TMain::BitBtn1Click(TObject *Sender)
{
    BYTE hBuf;
    int hBin = 0;
    int hExt = 0;
    int hLen = Edit3->Text.ToInt();
    if (FileExists(Edit1->Text))
    {
       TFileStream *hSource = new TFileStream(Edit1->Text,
       fmOpenRead | fmShareDenyWrite);
       Progress->Max = hSource->Size;
       for (int a = 0; a < hSource->Size; a++)
       {
          hExt++;
          AnsiString hName = Format("%s.%.3d", ARRAYOFCONST((Edit2->Text,
          hExt)));
          TFileStream *hTarget = new TFileStream(hName, fmCreate);
          do
          {
             hBin++;
             hSource->ReadBuffer (&hBuf, 1);
             hTarget->WriteBuffer(&hBuf, 1);
             Progress->Position = hSource->Position;
          }
          while (hBin != hLen);
          delete hTarget;
       }
       delete hSource;
       Progress->Position = 0;
    }
}

Thanks a lot,
Safari

Remy Thanks^(n+1),
Your source here is, work very fine & success.

void __fastcall TMain::BitBtn1Click(TObject *Sender)
{
    int iSourceFile = FileOpen(Edit1->Text, fmOpenRead
    | fmShareDenyWrite);
    if(iSourceFile != -1)
    {
       BYTE hBuf[50000];
       int iNum = 1;
       do
       {
          int iRead = FileRead(iSourceFile, hBuf, 50000);
          if(iRead != -1)
          {
             if(iRead == 0) break;
             AnsiString ext = Format("%.3d", ARRAYOFCONST((iNum)));
             ++iNum;
             int iNewFile = FileCreate(Edit2->Text + ext);
             if(iNewFile != -1)
             {
                if(FileWrite(iNewFile, hBuf, iRead) != iRead)
                FileClose(iNewFile);
             }
          }
       }
       while(true);
       FileClose(iSourceFile);
    }
}

Remy Lebeau (TeamB) wrote:
 > "Safari" <Safari@alloymail.com> wrote in message
 > news:3E955473.6000807@alloymail.com...
  >
 > No, you're not.  I've posted my code twice for you now, but your code, as
 > you've posted it here, still does not resemble my code at all. 
You're off
 > doing your own things.  My code does not use TFileStream and sets aside a
 > fixed-sized buffer and then read/wrote the files in full 50000b 
blocks at a
 > time.  Your code, on the other hand, is using TFileStream and is
 > reading/writing the files one byte at a time instead.

Hello,
You said to me:
Try to use "Read/Write(&hBuf, 1)"
instead "ReadBuffer/WriteBuffer(&hBuf, 1)"

Okey.
Thanks,

Remy Lebeau (TeamB) wrote:
 > "Safari" <Safari@alloymail.com> wrote in message
 > news:3E955473.6000807@alloymail.com...

Hello,
You said to me:
Try to use "Read/Write(&hBuf, 1)"
instead "ReadBuffer/WriteBuffer(&hBuf, 1)"

Okey.
Thanks,


"Remy Lebeau (TeamB)" <gambit47@yahoo.com> wrote in message
news:3e9619fe$1@newsgroups.borland.com...
|
| "Safari" <Safari@alloymail.com> wrote in message
| news:3E955473.6000807@alloymail.com...

"Safari" <Safari@alloymail.com> wrote in message
news:3E978BC8.2020907@alloymail.com...

> I say my source return error, not your source.

And I originally asked you if there was some reason why you weren't using my
source.  You never answered that question.

I've already made several comments repeatedly regarding problems with your
source, and I see you still haven't taken them into account yet.  Please go
re-read my earlier replies regarding how to fix your code, and stop posting
the same broken code over and over.


Gambit

Hello Remy,
I used your source and thanks,
but i want to complete my code
with your help. I want to use
from TFileStream.

Thanks,
Safari

"Remy Lebeau (TeamB)" <gambit47@yahoo.com> wrote in message
news:3e97ac20$1@newsgroups.borland.com...
|
| "Safari" <Safari@alloymail.com> wrote in message
| news:3E978BC8.2020907@alloymail.com...
|
| > I say my source return error, not your source.
|
| And I originally asked you if there was some reason why you weren't using
my
| source.  You never answered that question.
|
| Gambit

"Safari" <Safari@alloymail.com> wrote in message
news:3e99f994@newsgroups.borland.com...

> I used your source and thanks,
> but i want to complete my code
> with your help. I want to use
> from TFileStream.

Please re-read my earlier responses, I already pointed out how to fix
problems with your own code.


Gambit

Hello & Thanks Remy,
I not receive your replay!
Please send again.

Thanks a lot,
Safari

"Remy Lebeau (TeamB)" <gambit47@yahoo.com> wrote in message
news:3e9a0f44@newsgroups.borland.com...
|
| "Safari" <Safari@alloymail.com> wrote in message
| news:3e99f994@newsgroups.borland.com...
|
| > I used your source and thanks,
| > but i want to complete my code
| > with your help. I want to use
| > from TFileStream.
|
| Please re-read my earlier responses, I already pointed out how to fix
| problems with your own code.
|
| Gambit

"Safari" <Safari@alloymail.com> wrote in message
news:3e9ca2b5@newsgroups.borland.com...

> I not receive your replay!
> Please send again.

Please reset your newsreader to download previous messages again.  Or else
just go to www.deja.com or www.mers.com and search through the archives.
For example, our entire conversation is available here:

http://groups.google.com/groups?th=2ef5348ed2d12068
http://groups.google.com/groups?th=2ef5348ed2d12068

Namely, your loops are faulty and you're using the wrong TStream methods.


Gambit

Very thanks Remy,
Safari

"Remy Lebeau (TeamB)" <gambit47@yahoo.com> wrote in message
news:3e9ca86b$1@newsgroups.borland.com...
|
| "Safari" <Safari@alloymail.com> wrote in message
| news:3e9ca2b5@newsgroups.borland.com...
|
| > I not receive your replay!
| > Please send again.
|
| Please reset your newsreader to download previous messages again.  Or else
| just go to www.deja.com or www.mers.com and search through the archives.
| For example, our entire conversation is available here:
|
| http://groups.google.com/groups?th=2ef5348ed2d12068
| http://groups.google.com/groups?th=2ef5348ed2d12068
|
| Namely, your loops are faulty and you're using the wrong TStream methods.
|
| Gambit