🚀 go-pugleaf

Hi 

I had a problem with TBDEDataSet.Locate using a vararray with one
element as KeyValues. I got an "invalid variant conversion error", so
I started investigating. Stepping through the code I got to
TBDEDataSet.CreateLookupFilter. In DBTabls.pas:5268 it says:

if Fields.Count = 1 then
begin
  Node := Filter.NewCompareNode(TField(Fields[0]), coEQ, Values);
  Expr := Node;
end else
  for I := 0 to Fields.Count - 1 do
  begin
    Node := Filter.NewCompareNode(TField(Fields[I]), coEQ, Values[I]);
    if I = 0 then
      Expr := Node else
      Expr := Filter.NewNode(enOperator, coAND, Unassigned, Expr,
Node);
  end;

With one element in the array, Values is of type vararray of variant.
Later in the code it is converted to a string, resulting in the
exception.

Wouldn't it be better if 
  if Fields.Count = 1 then

was changed to

 if not IsVarArray(Values) then

This way, arrays with 1 element will work.

Regards,
Jesper Andersen
Developer
L-R Software A/S
Denmark