🚀 go-pugleaf

Changing this:

>function RotateByte( AByte : Byte;Positions : Byte ) : Byte;assembler;
>Asm
>  XOR EAX, EAX
>  Mov AL, AByte
>  ROL AL, Byte( Positions )
>end;

to this:
function RotateByte( AByte : Byte;Positions : Byte ) : Byte;assembler;
Asm
  XOR EAX, EAX
  MOV CL, Positions
  Mov AL, AByte
  ROL AL, CL
end;

Solved the compiler error :-)

Andrea Raimondi

--- posted by geoForum on http://delphi.newswhat.com

> function RotateByte( AByte : Byte;Positions : Byte ) : Byte;assembler;
> Asm
>  XOR EAX, EAX
>  MOV CL, Positions
>  Mov AL, AByte
>  ROL AL, CL
> end;


This is not going to work. Why XOR instruction? It clears AByte to zero.


function RotateByteLeft(AByte, Positions: Byte): Byte; register;
asm
 mov cl, dl
 rol al, cl
end;


Les. 

Andrea Raimondi wrote:
> Hello,
> 
> I'm using this code:
> 
> function RotateByte( AByte : Byte;Positions : Byte ) : Byte;assembler;
> Asm
>   XOR EAX, EAX
>   Mov AL, AByte
>   ROL AL, Byte( Positions )
> end;
> 
> The error says "[DCC Error] SchemaClasses.pas(112): E2116 Invalid 
> combination of opcode and operands" and it's quite some time I am not
> using BASM, so I'm at loss about how to fix the problem.

I suggest that you learn how Delphi passes parameters to function.
Hint:
EAX -> AByte
EDX -> Positions
ECX -> third parameter



-- 
Denomo: memory and resource leak detection tool, free open source
CodeHook: Win32 code/API hook for Delphi & C++, free open source
http://www.kbasm.com/

Les Pawelczyk wrote:
> function RotateByteLeft(AByte, Positions: Byte): Byte; register;
> asm
>  mov cl, dl
>  rol al, cl
> end;

That may lead to trouble with optimization enabled. Just use DL.

function RotateByteLeft(const AByte, Positions: Byte): Byte register; 
assembler;
asm
	rol	al, dl
end;

On Fri, 23 May 2008 16:23:28 +0100, Xavier <no@spam.com> wrote:

>Les Pawelczyk wrote:
>> function RotateByteLeft(AByte, Positions: Byte): Byte; register;
>> asm
>>  mov cl, dl
>>  rol al, cl
>> end;
>
>That may lead to trouble with optimization enabled. Just use DL.
>
>function RotateByteLeft(const AByte, Positions: Byte): Byte register; 
>assembler;
>asm
>	rol	al, dl
>end;

This will run in even more trouble because iut will not compile.
Perhaps you should read a book on ASM.

Wolfgang
-- 
In order to e-mail me a reply to this message, you will have 
to remove PLEASE.REMOVE from the address shown in the header
or get it from http://home.netsurf.de/wolfgang.ehrhardt
(Free open source Crypto, AES, CRC, Hash for Pascal/Delphi)

> That may lead to trouble with optimization enabled.

I'm not aware of any optimization issues here. Can you elaborate?


> rol al, dl

There is no such asm instruction.



Les. 

Does Delphi pass parameters in registers like that with optimisation off ?