🚀 go-pugleaf

Others have already correctly commented your abuse of "Randomize",
but there is another "feature" in your code which I believe is undesired:

Digit := Random(10) generates a single number (digit) in the range 0..9
and then you change every occurrence of the digit 0 to digit 1

This results is no zero digits and twice the count of number one digits to
what I assume you want (equal probability for each digit in the range)?

regards Sven

"Eugene V. Goldberg" <egold@mts-nn.ru> wrote in message
news:4014fbf5@newsgroups.borland.com...
> I have the following functions:
>
> function TfrmTickets.GetLogin(Prefix: String): String;
> var
>   i, Digit: Integer;
> begin
>   Result := Prefix;
>   Randomize;
>   for i := Length(Result) + 1 to 8 do
>   begin
>     Digit := Random(10);
>     if Digit = 0 then
>       Digit := 1;
>     Result := Result + IntToStr(Digit)
>   end;
> end;
>
> function TfrmTickets.GetPassword: String;
> var
>   i, Digit: Integer;
> begin
>   Randomize;
>   Result := '';
>   for i := 1 to 8 do
>   begin
>     Digit := Random(10);
>     if Digit = 0 then
>       Digit := 1;
>     Result := Result + IntToStr(Digit)
>   end;
> end;
>
> I am calling this functions one after another in a loop, 10 times.
> And as the result i have login = password = somestring1 for 4 calls,
> login = password = somestring2 for other 6 calls. So i have the same
> strings generated several times. Whats wrong?
>
> I need to generate different values for login and password every time.
>
> Thanx,
> Eugene.
>
>