🚀 go-pugleaf

In article <3dde225f$1@newsgroups.borland.com>, Stephen Froude says...

> 
> >Are you sure that qryStatus.FieldByName('oldstatus').AsInteger return a
> >value between 10 and 1000, where 10 and 1000 in included?
> 
> Thanks for your reply. Yes, I'm getting the value 370 in my testing.
> 
> I've just created a new app with the following code to make sure, any ideas?
> 
> procedure TForm1.Button1Click(Sender: TObject);
> const
>   STATUS_NEW: Integer = 100;
>   STATUS_CANCELLED: Integer = 1000;
> var
>   iStatus: Integer;
> begin
>   iStatus := 370;
>   if (iStatus in [STATUS_NEW..STATUS_CANCELLED]) then
>     ShowMessage('Hello');
> end;

Do you have range checking on? If you do (you should *always* do that, 
even in deployed code), you'll get a range check error, and rightly so.

Why? Because [100..1000] would be a set, and a set can only contain 
values 0..255. So without range checking, you probably get [100..1000 
mod 256], or [100..232].

Because your values are not constant expressions, like [100..1000], you 
won't get a compile time error. That is because your constants are not 
true constants, they are typed constants.

Try this instead:

  procedure TForm1.Button1Click(Sender: TObject);
  const
    STATUS_NEW = 100;
    STATUS_CANCELLED = 1000;
  var
    iStatus: Integer;
  begin
    iStatus := 370;
    if (iStatus in [STATUS_NEW..STATUS_CANCELLED]) then
      ShowMessage('Hello');
  end;

And you'll see it won't compile:

  [Error] InOperatorTest.pas(34): Constant expression violates subrange   
bounds

Line 34 is the if clause.
-- 
Rudy Velthuis (TeamB)

"We should leave our minds open, but not so open that our brains 
 fall out." - Alan Ross Anderson