🚀 go-pugleaf

>3.        TargetNode newNode = (TargetNode) ((Cloneable)node).clone();


The Cloneable interface does not define any members, so it does not make
sense to ever cast to it.  In the above case, the code is obviously aware
that it is cloning a TargetNode, so you should instead write

// -->
TargetNode node;
...
if (node instanceof Cloneable)
{
try
{
TargetNode newNode = (TargetNode)node.clone();
}
catch (CloneNotSupportedException k)
{}
}
// <--

The interface TargetNode should have a clone method:

// -->
interface TargetNode
{
Object clone() throws CloneNotSupportedException;
...
}
// <--

This ensures that clone() is public.  If you want to ensure that every class
implementing the TargetNode interface supports cloning, then do

// -->
interface TargetNode
extends Cloneable
{
Object clone();
...
}
// <--

Then you would just write

// -->
TargetNode node;
...
TargetNode newNode = (TargetNode)node.clone();
/ <--


Aaron Gaalswyk