Article View: borland.public.jbuilder.java.language
Article #7340Re: firing property change events: use copies or originals?
From: Rich Wilkman
Date: Wed, 27 Jun 2001 16:58
Date: Wed, 27 Jun 2001 16:58
45 lines
2923 bytes
2923 bytes
At a minimum you should make your code robust enough to take bogus values and nulls from the user and either defang them or put your image back. I don't understand why "private" is crazy, though. Data hiding and limiting access is quite good. I have plenty of beans with private members, public getters but only package local setters. That makes things a little easier on my side and provides a good level of protection and visibility for the client. -Rich dnoyeB wrote: > > Well yea, when its my code. But this is a bean, and the end user may get > happy and start fiddling around with the innards of the object I pass back. > Its crazy I know, but so is using "private." Its an ImageIcon, he could > easily replace the image itholds, or set its internal image to null. My > bean would not like that. Thats why im considering the copy. ImageIcon > does not have a copy constructor though... > > "John McGrath [TeamB]" <ng-b@JPMcGrath.net> wrote in message > news:MPG.15a34d4ad4cde13a98a2e5@forums.borland.com... > > On Tue, 26 Jun 2001 15:12:10 -0400, "dnoyeB" <lamont_gilbert @ > > rigidsoftware.com> wrote: > > > > > HOwever, I am concerned about passing the old object reference > > > into this event to be handed around and molested/violated. I > > > would prefer to pass a copy of the object, but is this proper? > > > > I do not think you have to create a copy, but there is no reason that > > it would not work. Well behaved code should probably not be changing > > the objects passed to it in a property change notification, so I do not > > think it is really necessary in most cases. Depending on how many such > > events are generated, it could become a performance issue if you copy > > the object. > > > > -- > > Regards, > > > > John McGrath [TeamB] > > > > --------------------------------------------------- > > Before sending me e-mail, please read: > > http://www.JPMcGrath.net/newsgroups/e-mail.html
Technical Details
Message-ID:
<3B3A10A0.864A0F91@formlessvoid.com>Path:
arc1-ca.pugleaf.net!archiver1.google.com!newsfeed.google.com!sn-xit-02!supernews.com!nntp-relay.ihug.net!newsfeeds.ihug.co.nz!ihug.co.nz!dnewsReferences:
<3b38df5b$3_1@dnews> <MPG.15a34d4ad4cde13a98a2e5@forums.borland.com> <3b39da81$1_1@dnews>Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: f74b3,88b4b8db5c548e01 X-Google-Attributes: gidf74b3,public X-Google-ArrivalTime: 2001-06-27 10:18:19 PST Message-ID: <3B3A10A0.864A0F91@formlessvoid.com> Date: Wed, 27 Jun 2001 09:58:08 -0700 From: Rich Wilkman <richw@formlessvoid.com> X-Mailer: Mozilla 4.77 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 Newsgroups: borland.public.jbuilder.java.language Subject: Re: firing property change events: use copies or originals? References: <3b38df5b$3_1@dnews> <MPG.15a34d4ad4cde13a98a2e5@forums.borland.com> <3b39da81$1_1@dnews> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit NNTP-Posting-Host: 208.236.69.60 X-Trace: dnews 993661088 208.236.69.60 (27 Jun 2001 09:58:08 -0700) Lines: 45 Path: arc1-ca.pugleaf.net!archiver1.google.com!newsfeed.google.com!sn-xit-02!supernews.com!nntp-relay.ihug.net!newsfeeds.ihug.co.nz!ihug.co.nz!dnews