🚀 go-pugleaf

Hello!

I've written a simple object which accepts a File[] array and compresses it
with a ZipOutputStream object to a given OutputStream.
It works fine. The only problem is when I try to compress about 12MB, it
take about 50 seconds to complete while WinZip does it in 6 seconds.

Does my code has a logical flaw? Do I need to do something with the
buffering?

The compressor object:

import java.util.zip.*;
import java.io.*;


/**
 * This class compresses files with the zip format and writes the output to
a specified OutputStream.
 */

public class ZipCompressor {

  private ZipOutputStream out;


  /**
   * The constructor accepts an OutputStream object to which the data will
be written to.
   *
   * @param outputStream - the outputstream to which the compressed files
will be written.
   */

  public ZipCompressor(OutputStream outputStream) {
    out = new ZipOutputStream(new BufferedOutputStream(outputStream));
  }


  /**
   * The method accepts a File array containing the files to compress.
   *
   * @param files - a File array containing the desired files to compress.
   *
   * @throws FileNotFoundException - if a file in the array is not found.
   * @throws IOException - if an IOException occurs.
   */

   public void compressFiles(File[] files) throws FileNotFoundException,
IOException {
     for(int i = 0; i < files.length; i++)
     {
       String fileName = files[i].getName();

       out.putNextEntry(new ZipEntry(fileName));
       BufferedReader in = new BufferedReader(new FileReader(files[i]));

       int c;

       while((c = in.read()) != -1)
         out.write(c);

       in.close();

     } // end for loop
   }


   /**
    * Writes the compressed data to the outputstream (which was specified in
the constructor).
    *
    * @throws IOException - if the closing the stream fails.
    */

   public void write() throws IOException {
     out.flush();
     out.close();
   }

} // end class ZipCompressor


============================================================================
============
The main() :

import java.io.*;

public class Test {


  public static void main(String[] args) {

    File[] files = {
                     new File("d:/java/tests/tests.jpr"),
                     new File("D:/JBuilder4/jdk1.3/jre/lib/rt.jar"),
                   };

    long start = System.currentTimeMillis();

    try {
      ZipCompressor compressor = new ZipCompressor(new
FileOutputStream("d:/test.zip"));
      compressor.compressFiles(files);
      compressor.write();
    } catch(Exception x) { x.printStackTrace(); }

    long stop = System.currentTimeMillis();

    System.out.println("Total seconds: " + (stop - start) / 1000);
  }

} // end class Test



Thanks!!!!