🚀 go-pugleaf

>read:
>	    get the block from disk
>	    copy it out to the user buffer
>	    return
>
>mmap:
>	    get the block from disk
>	    map it into the user's address space
>	    return
>
>It seems to me that there is in extra copy in there.  In kernels that I've
>profiled, this copy shows up very high on the list (in the top 2 or 3).

How about:

read:
    get the block from disk
    if the user buffer is page aligned
    	map it into the user address space
    else
    	copy it
    return

or even, if you are expecting the data not to be reused,
and your I/O system can do copies to arbitrary locations

read:
    lock the pages containing the user buffer down
    tell the I/O controller to write directly into the user memory.

--
Andy Glew, aglew@uiuc.edu