🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.bugs.4bsd.ucb-fixes
Article #39

V1.28 (dump fails to write highest numbered inode to tape)

#39
From: Keith Bostic
Date: Thu, 18 Jun 1987 18:39
30 lines
1561 bytes
Subject: dump fails to write highest numbered inode to tape
Index: etc/dump/dumptraverse.c 4.3BSD

Description:
	The highest-numbered inode (maxino) on a file system is never
	written to tape by dump(8).  Maxino is calculated correctly,
	but the for-loop test clause is written incorrectly such that
	dump(8) stops processing inodes at maxino - 1.
Fix:
	Apply the following patch.

*** dumptraverse.c.old	Thu Jun 18 11:02:26 1987
--- dumptraverse.c.new	Thu Jun 18 11:03:33 1987
***************
*** 18,24 ****
  	ino_t maxino;
  
  	maxino = sblock->fs_ipg * sblock->fs_ncg - 1;
! 	for (ino = 0; ino < maxino; ) {
  		if ((ino % NBBY) == 0) {
  			bits = ~0;
  			if (map != NULL)
--- 18,24 ----
  	ino_t maxino;
  
  	maxino = sblock->fs_ipg * sblock->fs_ncg - 1;
! 	for (ino = 0; ino <= maxino; ) {
  		if ((ino % NBBY) == 0) {
  			bits = ~0;
  			if (map != NULL)
Technical Details
Message-ID: <8706181839.AA14748@okeeffe.Berkeley.EDU>
Path: arc1-ca.pugleaf.net!utzoo!mnetor!seismo!gatech!hao!husc6!think!ames!ucbcad!ucbvax!OKEEFFE.BERKELEY.EDU!bostic

Show Full Headers
Complete Article Headers
Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: arc1-ca.pugleaf.net!utzoo!mnetor!seismo!gatech!hao!husc6!think!ames!ucbcad!ucbvax!OKEEFFE.BERKELEY.EDU!bostic
From: bostic@OKEEFFE.BERKELEY.EDU (Keith Bostic)
Newsgroups: comp.bugs.4bsd.ucb-fixes
Subject: V1.28 (dump fails to write highest numbered inode to tape)
Message-ID: <8706181839.AA14748@okeeffe.Berkeley.EDU>
Date: Thu, 18-Jun-87 14:39:42 EDT
Article-I.D.: okeeffe.8706181839.AA14748
Posted: Thu Jun 18 14:39:42 1987
Date-Received: Sun, 21-Jun-87 14:32:54 EDT
Sender: daemon@ucbvax.BERKELEY.EDU
Distribution: world
Organization: The ARPA Internet
Lines: 30
Approved: ucb-fixes@okeeffe.berkeley.edu