🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.bugs.4bsd
Article #161

Patch: Sendmail 5.61 core dumps on long lists

#161
From: Reg Quinton
Date: Wed, 30 May 1990 19:55
28 lines
1241 bytes
We were having trouble with sendmail core dumping when dealing with
long recipient lists (at least with 5.61 on our Mips machine). I
managed to localize the problem into deliver.c and the deliver()
procedure where the string array "tobuf" was causing the problem -- to
much data was being written into the array and this was corrupting
other structures on the stack.

The following patch fixed that problem.

*** deliver.c	Wed May 30 14:45:02 1990
--- deliver.c.orig	Wed May 30 15:35:32 1990
***************
*** 221,227 ****
  			continue;
  
  		/* avoid overflowing tobuf */
! 		if ((strlen(to->q_paddr) + strlen(tobuf) + 2) > sizeof(tobuf))
  			break;
  
  		if (tTd(10, 1))
--- 221,227 ----
  			continue;
  
  		/* avoid overflowing tobuf */
! 		if (sizeof tobuf - (strlen(to->q_paddr) + strlen(tobuf) + 2) < 0)
  			break;
  
  		if (tTd(10, 1))
Technical Details
Message-ID: <432@ria.ccs.uwo.ca>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!watserv1!ria!reggers

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!watserv1!ria!reggers
From: reggers@ria.ccs.uwo.ca (Reg Quinton)
Newsgroups: comp.bugs.4bsd,comp.mail.sendmail,comp.sys.mips
Subject: Patch: Sendmail 5.61 core dumps on long lists
Message-ID: <432@ria.ccs.uwo.ca>
Date: 30 May 90 19:55:40 GMT
Followup-To: comp.bugs.4bsd
Organization: Univ. Western Ontario, London Ont. CA
Lines: 29