Article View: comp.bugs.4bsd
Article #366Re: Bug in 386BSD, Net-2 telnets, Berkeley telnet.91.03.25: "send ayt" doesn' t work
From: Christos Zoulas
Date: Wed, 18 Nov 1992 20:56
Date: Wed, 18 Nov 1992 20:56
48 lines
1817 bytes
1817 bytes
In article <1ebvb1INNe3t@ef2007.efhd.ford.com> "Mike O'Connor" <mjo@fmsrl7.srl.ford.com> writes:
>In article <1992Nov17.041308.5252@CSD-NewsHost.Stanford.EDU>
>jonathan@CS.Stanford.EDU (Jonathan Stone) writes:
>
>:Index::
>: telnet SEND command broken in client (e.g., SEND AYT)
>
>For what it's worth, the bug appears in BSDI Gamma as well.
>
And here's the patch I sent to Keith Bostic...
As you can see by inspecting the code, the variable 'what' is never
initialized...
christos
*** /tmp/T0a29914 Wed Nov 18 15:54:58 1992
--- commands.c Mon Oct 26 21:26:30 1992
***************
*** 291,297 ****
int argc;
char **argv;
{
- int what; /* what we are sending this time */
int count; /* how many bytes we are going to need to send */
int i;
int question = 0; /* was at least one argument a question */
--- 291,296 ----
***************
*** 364,371 ****
(s->narg > 1) ? argv[i+2] : 0);
i += s->narg;
} else {
! NET2ADD(IAC, what);
! printoption("SENT", IAC, what);
}
}
return (count == success);
--- 363,370 ----
(s->narg > 1) ? argv[i+2] : 0);
i += s->narg;
} else {
! NET2ADD(IAC, s->what);
! printoption("SENT", IAC, s->what);
}
}
return (count == success);
Technical Details
Message-ID:
<BxxJIA.AxA@deshaw.com>Path:
arc1-ca.pugleaf.net!sparky!uunet!deshaw.com!christosReferences:
<1992Nov17.041308.5252@CSD-NewsHost.Stanford.EDU> <1ebvb1INNe3t@ef2007.efhd.ford.com>Show Full Headers
Complete Article Headers
Newsgroups: comp.bugs.4bsd Path: arc1-ca.pugleaf.net!sparky!uunet!deshaw.com!christos From: christos@deshaw.com (Christos Zoulas) Subject: Re: Bug in 386BSD, Net-2 telnets, Berkeley telnet.91.03.25: "send ayt" doesn' t work Message-ID: <BxxJIA.AxA@deshaw.com> Sender: usenet@deshaw.com Nntp-Posting-Host: prefect Organization: D. E. Shaw & Co. References: <1992Nov17.041308.5252@CSD-NewsHost.Stanford.EDU> <1ebvb1INNe3t@ef2007.efhd.ford.com> Date: Wed, 18 Nov 1992 20:56:33 GMT Lines: 48