🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.bugs.4bsd
Article #380

Re: error handling bug in sendoff() of sendmail 5.65

#380
From: DEMIZU Noritoshi
Date: Sat, 18 May 1991 12:47
56 lines
2492 bytes
In article <1227@nikhefh.nikhef.nl>
	e07@nikhefh.nikhef.nl (Eric Wassenaar) writes:

 |Because unfortunately I was looking at an old version of sendmail,
 |in which messages were requeued by markfailure() only for EX_TEMPFAIL.
 |The latest versions indeed will requeue on status codes EX_TEMPFAIL,
 |EX_IOERR, and EX_OSERR in markfailure().

I should say again that I did not check sendmail 5.65 source code
carefully.  I only looked at 5.61 source code.

I'll post patch again to avoid confusion.  Is this correct patch?

 --- DEMIZU Noritoshi    OMRON Corporation

=====================================================================
*** src/deliver.c.ORG	Sat May  4 14:32:51 1991
--- src/deliver.c	Sat May  4 14:33:45 1991
***************
*** 600,606 ****
  
  	pid = openmailer(m, pvp, ctladdr, FALSE, &mfile, &rfile);
  	if (pid < 0)
! 		return (-1);
  
  	/*
  	**  Format and send message.
--- 600,606 ----
  
  	pid = openmailer(m, pvp, ctladdr, FALSE, &mfile, &rfile);
  	if (pid < 0)
! 		return ExitStat;
  
  	/*
  	**  Format and send message.
*** support/getloadavg.c.ORG	Sat May  4 15:58:47 1991
--- support/getloadavg.c	Sat May  4 15:58:59 1991
***************
*** 42,47 ****
  			return (-1);
  	}
  	if (lseek(kmem, (off_t) Nl[X_AVENRUN].n_value, 0) == -1 ||
! 	    read(kmem, (char *) avenrun, sizeof(avenrun)) < sizeof(avenrun))
  		return (-1);
  }
--- 42,47 ----
  			return (-1);
  	}
  	if (lseek(kmem, (off_t) Nl[X_AVENRUN].n_value, 0) == -1 ||
! 	    read(kmem, (char *) avenrun, sizeof(*avenrun)) < sizeof(*avenrun))
  		return (-1);
  }
=====================================================================
--
;  DEMIZU, Noritoshi		OMRON Computer Systems R&D laboratory
;  demizu@nff.ncl.omron.co.jp	tel: 075-951-5111  fax: 075-956-7403
Technical Details
Message-ID: <DEMIZU.91May18214753@banquo.nff.ncl.omron.co.jp>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!news-server.csri.toronto.edu!rpi!usc!cs.utexas.edu!sun-barr!ccut!wnoc-tyo-news!astemgw!choshi!frf!demizu
References: <DEMIZU.91May4162444@freezer.nff.ncl.omron.co.jp> <1991May7.114948.16201@mp.cs.niu.edu> <1227@nikhefh.nikhef.nl>

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!news-server.csri.toronto.edu!rpi!usc!cs.utexas.edu!sun-barr!ccut!wnoc-tyo-news!astemgw!choshi!frf!demizu
From: demizu@nff.ncl.omron.co.jp (DEMIZU Noritoshi)
Newsgroups: comp.bugs.4bsd
Subject: Re: error handling bug in sendoff() of sendmail 5.65
Message-ID: <DEMIZU.91May18214753@banquo.nff.ncl.omron.co.jp>
Date: 18 May 91 12:47:53 GMT
References: <DEMIZU.91May4162444@freezer.nff.ncl.omron.co.jp>
 <1991May7.114948.16201@mp.cs.niu.edu> <1227@nikhefh.nikhef.nl>
Sender: news@frf.omron.co.jp
Distribution: comp
Organization: OMRON Corporation, Kyoto, Japan.
Lines: 56
In-reply-to: e07@nikhefh.nikhef.nl's message of 7 May 91 14:13:57 GMT