Re: Obscure bug in ci,co,rcs

Article View: comp.bugs.sys5

Article #584

#584

From: Roy Morris
Date: Thu, 03 Sep 1987 20:13

16 lines
1249 bytes

In article <317@jpusa1.UUCP> stu@jpusa1.UUCP (Stu Heiss) writes:
>An obscure bug surfaced when trying to co a bunch of
>files.  The variable 'linecorr' is not initialized to
>0 for each file.  This will cause editstring to break
>if linecorr happened to be < 0 at the end of doing the
>last file.  Following are diffs to rcs.c and rcsgen.c

A cleaner fix to the problem is to add the following line to the
routine initeditfiles() in rcsedit.c.  We weren't bitten by the
variable 'editline' not being initialized, but it's not worth
waiting to see if it happens.

88a89
> 	editline = linecorr = 0;

Roy Morris   FileNet Corp   ...!felix!roy

Technical Details

Message-ID: <6712@felix.UUCP>

Path: arc1-ca.pugleaf.net!utzoo!mnetor!uunet!seismo!ll-xn!ames!oliveb!felix!roy

References: <317@jpusa1.UUCP>

Show Full Headers

Complete Article Headers

Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: arc1-ca.pugleaf.net!utzoo!mnetor!uunet!seismo!ll-xn!ames!oliveb!felix!roy
From: roy@felix.UUCP (Roy Morris)
Newsgroups: comp.bugs.sys5,comp.bugs.4bsd,comp.bugs.misc
Subject: Re: Obscure bug in ci,co,rcs
Message-ID: <6712@felix.UUCP>
Date: Thu, 3-Sep-87 16:13:08 EDT
Article-I.D.: felix.6712
Posted: Thu Sep  3 16:13:08 1987
Date-Received: Sat, 5-Sep-87 17:21:57 EDT
References: <317@jpusa1.UUCP>
Sender: daemon@felix.UUCP
Reply-To: roy@felix.UUCP (Roy Morris)
Organization: FileNet Corp., Costa Mesa, CA
Lines: 16
Summary: cleaner fix

Reply to Parent Message