🚀 go-pugleaf

"MikeG in Philly" <PhilaPA@hotmail.com> wrote in message news:38cae00b@news3.enter.net...

> Hi Folks: the following code snippet is a loop for a password, and it works
> fine as it is...but I need to give the user three tries before exiting the
> sub and can't figure out the loop...can you help?

> Here's the code...


> Private Sub cmdOK_Click()

> Dim strLName As String
> Dim strPW1 As String
> Dim strLevel As String
> intCount = intCount + 1

Is intCount a global, form-level, or static variable, or what?

>     Open "a:\password.dat" For Input As #1
>         Do While Not EOF(1)
>         Input #1, strLName, strPW1, strLevel
>
>         If LCase(Trim(strLName)) = LCase(Trim(txtUserName.Text)) And
> LCase(Trim(strPW1)) = LCase(Trim(txtPassword.Text)) And

Why shouldn't the password be case sensitive? Check out StrComp in the help.

> LCase(Trim(strLevel)) = 3 Then
>              frmMain.Show
>              Me.Hide
>              Close #1
>              Exit Sub
>
>         Else

Either use ElseIf or fix your indenting.

>         If LCase(Trim(strLName)) = LCase(Trim(txtUserName.Text)) And
> LCase(Trim(strPW1)) = LCase(Trim(txtPassword.Text)) And
> LCase(Trim(strLevel)) = 2 Then
>              Me.Hide
>              frmMain.Show
>              frmMain.cmdAssign.Visible = False
>              frmTables.cmdOrders.Visible = False
>              frmTables.cmdOL.Visible = False
>              frmTables.cmdPurch.Visible = False
>                 frmTables.cmdCR.Visible = False
>                 Close #1
>                 Exit Sub
>         Else
>         If LCase(Trim(strLName)) = LCase(Trim(txtUserName.Text)) And
> LCase(Trim(strPW1)) = LCase(Trim(txtPassword.Text)) And
> LCase(Trim(strLevel)) = 1 Then
>         Me.Hide
>         frmMain.cmdView.Visible = False
>         frmMain.Show
>         Close #1
>         Exit Sub

>         End If
>         End If
>         End If

>         Loop


>         Close #1
>         MsgBox "Sorry, wrong password."

> End Sub

Here's how I might do it, based on what you've shown us:

Open "a:\password.dat" For Input As #1
Do While intCount > 0 And Not EOF(1)
    Input #1, strLName, strPW1, strLevel

    If StrComp(strLName, txtUserName.Text, 0) <> 0 Then
        ' nope
    ElseIf StrComp(strPW1, txtPassword.Text, 0) <> 0 Then
        ' sorry
    ElseIf strLevel = 3 Then
        intCount = 0
    ElseIf strLevel = 2 Then
        intCount = 0
        frmMain.cmdAssign.Visible = False
        frmTables.cmdOrders.Visible = False
        frmTables.cmdOL.Visible = False
        frmTables.cmdPurch.Visible = False
        frmTables.cmdCR.Visible = False
    ElseIf strLevel = 1 Then
        intCount = 0
        frmMain.cmdView.Visible = False
    End If
Loop
Close #1

If IntCount = 0 Then
    frmMain.Show
    Me.Hide
ElseIf IntCount < 3 Then
    txtPassword.Text = vbNullString
    txtPassword.SetFocus
    MsgBox "Sorry, wrong password."
ElseIf IntCount = 3 Then
    MsgBox "Game over, man! Game over!"
    Unload Me
End If

I'd really want to use at least a one-way hash for that password file.

--
Joe Foster <mailto:jfoster@ricochet.net>  Space Cooties! <http://www.xenu.net/>
WARNING: I cannot be held responsible for the above        They're   coming  to
because  my cats have  apparently  learned to type.        take me away, ha ha!