🚀 go-pugleaf

Jon Skeet <skeet@pobox.com> wrote:

> Rosinger <rosinger@optushome.com.au> wrote:
>>           System.out.println (response);
>> 
>>           in.close();
>>           out.close();
>>           socket.close();
>>      }
>> }
> 
> These close calls should be part of a finally block, so they get 
> executed even if an IO exception is thrown.

What is the best way to close multiple streams? This ofcourse depends 
on whether the method has been declared to throw an IOException. I've 
considered a lot of different approaches, but I haven't found a winner 
yet. Some of the better:

Doesn't throw an IOException:

    try {
      // ...
    } finally { 
      closeIfNonNullAndIgnoreIOException(in);
      closeIfNonNullAndIgnoreIOException(out);
      closeIfNonNullAndIgnoreIOException(socket);
    }

Throws an IOException:

    try {
      // ...
    } catch(IOException e) {
      closeIfNonNullAndIgnoreIOException(in);
      in = null;
      closeIfNonNullAndIgnoreIOException(out);
      out = null;
      closeIfNonNullAndIgnoreIOException(socket);
      socket = null;
      throw e;
    } finally { 
      try {
        if(in != null) in.close();
      } finally { 
        try {
          if(out != null) out.close();
        } finally {
          if(socket != null) socket.close();
        }
      }
    }

-- 
No address munging in use. I like the smell of nuked accounts in the 
morning.