🚀 go-pugleaf

Andy Zaidman wrote:
> 
> Well, it seems to me as if this algo just doesn't do the job... The problem
> is that in your example the 2 biggest values are in the upper half of your
> list of numbers... So, when you divide the list in 2, it will return the
> biggest numbers of each of the halves... and not the biggest numbers of the
> entire list...

OK, I think I have found my problem:

I should replace this...
	
<BEGIN OLD CODE>
	
	    /* 
	     * Recursive function call on left and right side
	     */
	    BigThings leftBigThings = left.searchTwoBiggest();
	    BigThings rightBigThings = right.searchTwoBiggest();
	    
	    if (leftBigThings.getBiggest()>rightBigThings.getBiggest()) {
		$values.setBiggest(leftBigThings.getBiggest());
		if (leftBigThings.getSecondBiggest()>rightBigThings.getBiggest())
		    $values.setSecondBiggest(leftBigThings.getSecondBiggest());
	    }
	    else {
		$values.setBiggest(rightBigThings.getBiggest());
		if (rightBigThings.getSecondBiggest()>leftBigThings.getBiggest())
		    $values.setSecondBiggest(rightBigThings.getSecondBiggest());
	    }
	}

<END OLD CODE>

With this...

<BEGIN NEW CODE>
	
	    /* 
	     * Recursive function call on left and right side
	     */
	    BigThings leftBigThings = left.searchTwoBiggest();
	    BigThings rightBigThings = right.searchTwoBiggest();
	    
	    if (leftBigThings.getBiggest()>rightBigThings.getBiggest()) {
		$values.setBiggest(leftBigThings.getBiggest());
		if (leftBigThings.getSecondBiggest()>rightBigThings.getBiggest())
		    $values.setSecondBiggest(leftBigThings.getSecondBiggest());
		else
		    $values.setSecondBiggest(rightBigThings.getBiggest());
	    }
	    else {
		$values.setBiggest(rightBigThings.getBiggest());
		if (rightBigThings.getSecondBiggest()>leftBigThings.getBiggest())
		    $values.setSecondBiggest(rightBigThings.getSecondBiggest());
		else 
		    $values.setSecondBiggest(leftBigThings.getBiggest());
	    } 

<END NEW CODE>

I think adding these two 'else' clauses at the end of both cases solves my
problem because this way the second biggest value is always set.
Could somebody verify this?

Greetzzz,
mc303

--
Ing. Bart Vandewoestyne			  Bart.Vandewoestyne@skynet.be
Hugo Verrieststraat 48			       GSM: +32 (0)478 397 697
B-8550 Zwevegem					 http://hello.to/MC303
----------------------------------------------------------------------
"Any fool can know, the point is to understand." - Albert Einstein