🚀 go-pugleaf

On Aug 29,  2:33am, Roger Cornelius wrote:
} Subject: Re: Bug in mush 7.2.4
}
} In article <1052@alsys1.aecom.yu.edu>, rnb@alsys1.aecom.yu.edu (Robert N. Berlinger) writes:
} > Also, for the last several version of mush at least, pick -ago seems
} > to glitch out, e.g., doing a pick -ago -1w says
} > 
} > Searching for messages that contain "w l
} > 					".
} 
} I can confirm this also, in 7.2.4 at least.  I don't have time to
} track it down unfortunately.  mush is compiled using regcmp() and
} friends, if that's any help.  regcmp is mentioned in the error message.
} It appears regcmp is being passed an unitialized pointer.

Has nothing to do with regcmp().  The patch below will be included in patch
#5, to be out Real Soon Now [next week].  Mush has now been sent through the
"purify" memory leak/corruption checker and a lot of bugs in the new POP
code were squashed.  Mush itself passes with flying colors (no warnings and
zero leaked bytes, though I haven't purified the SunView part).

*** pick.c	Wed Nov 20 23:42:33 1991
--- /tmp/d13841	Mon Sep  7 08:52:10 1992
***************
*** 74,80 ****
      head_cnt = tail_cnt = -1;
      match_priority = 0;
      icase = before = after = search_from = search_subj = search_to = xflg = 0;
!     mdy[0] = mdy[1] = search_hdr[0] = 0;
      while (*argv && *++argv && (**argv == '-' || **argv == '+'))
  	if (**argv == '+' || isdigit(argv[0][1])) {
  	    if (**argv == '+')
--- 74,80 ----
      head_cnt = tail_cnt = -1;
      match_priority = 0;
      icase = before = after = search_from = search_subj = search_to = xflg = 0;
!     pattern[0] = mdy[0] = mdy[1] = search_hdr[0] = 0;
      while (*argv && *++argv && (**argv == '-' || **argv == '+'))
  	if (**argv == '+' || isdigit(argv[0][1])) {
  	    if (**argv == '+')
***************
*** 166,172 ****
  	return -1;
      }
      if (!mdy[1]) {
- 	pattern[0] = 0;
  	(void) argv_to_string(pattern, argv);
  	if (pattern[0] == '\0' && match_priority == 0 &&
  		head_cnt + tail_cnt < 0) {
--- 166,171 ----

-- 
Bart Schaefer                                     schaefer@zigzag.z-code.com
Z-Code Software Corp.                             schaefer@z-code.com