🚀 go-pugleaf

This is a followup to my earlier post about fixing the toupper() and
tolower() macros in the ctype.h currently in the gcc/2 distribution.

I think I must of been half-asleep when I wrote it :-( My suggested
fix will not, of course, work if the argument expression has
side-effects. For example, toupper(*p++) will lose, since the pointer
will be incremented twice.

In any case Eberhard Mattes already put a better fix in emx, namely
this: 

static __inline__ int _toupper (int c) { return (c-'a'+'A'); }
static __inline__ int _tolower (int c) { return (c-'A'+'a'); }
static __inline__ int toupper(int c) {return (islower(c) ? _toupper(c) : c);}
static __inline__ int tolower(int c) {return (isupper(c) ? _tolower(c) : c);}

I only thought to check the emx ctype.h _after_ I wrote the preceeding
note :-( :-(. Being proper functions, these will not be vulnerable to
expressions with side effects, and the compiler will also type check
your argument and return value while it is at it.

With reddened face...

Paul Lyon