Article View: comp.protocols.time.ntp
Article #921Re: Bug in xntp version 1.3 in clock selection
From: Martyn Johnson
Date: Fri, 07 Jun 1991 07:56
Date: Fri, 07 Jun 1991 07:56
50 lines
2274 bytes
2274 bytes
> How does one determine what version?
It's in the file "version.c".
> What is the version now available on louie.udel.edu ??
1.3, I believe. But somebody recently posted something referring
to 1.4 - where is this I wonder?
> I wonder if the bug is fixed in the source on louie.udel.edu
I acquired my copy fairly recently, and it definitely has this bug.
While we're here, a couple of other minor problems with xntp 1.3
1. A misfeature: It UNCONDITIONALLY sets its "nice" value to -12.
This defeats any attempt to run it at even more negative nice
levels. This caught me out because I have other daemons running
at nice -15 and want to run xntpd at even higher priority.
2. The log message generated when the local clock is stepped only
prints the offset to one significant figure. At least, that's
what it does for me - since this is caused by a missing argument
to a function, it could have different effects on different
systems. Here's a patch:
*** 1.1 1991/06/03 09:18:13
--- ntp_loopfilter.c 1991/06/03 09:19:31
***************
*** 117,123 ****
if (tmp_ui > CLOCK_MAX_I || (tmp_ui == CLOCK_MAX_I
&& (u_long)tmp_uf >= (u_long)CLOCK_MAX_F)) {
syslog(LOG_DEBUG, "adjust: STEP %s offset %s\n",
! ntoa(from), lfptoa(fp_offset));
step_systime(fp_offset);
clock_adjust = 0;
--- 117,123 ----
if (tmp_ui > CLOCK_MAX_I || (tmp_ui == CLOCK_MAX_I
&& (u_long)tmp_uf >= (u_long)CLOCK_MAX_F)) {
syslog(LOG_DEBUG, "adjust: STEP %s offset %s\n",
! ntoa(from), lfptoa(fp_offset, 9));
step_systime(fp_offset);
clock_adjust = 0;
----------
Martyn Johnson maj@cl.cam.ac.uk
University of Cambridge Computer Lab
Cambridge UK
Technical Details
Message-ID:
<1991Jun7.075643.11097@cl.cam.ac.uk>Path:
arc1-ca.pugleaf.net!utzoo!utgpu!news-server.csri.toronto.edu!rpi!zaphod.mps.ohio-state.edu!wuarchive!uunet!mcsun!ukc!cam-cl!newsReferences:
<9106061825.AA01752@windsail.nersc.gov>Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!news-server.csri.toronto.edu!rpi!zaphod.mps.ohio-state.edu!wuarchive!uunet!mcsun!ukc!cam-cl!news From: maj@cl.cam.ac.uk (Martyn Johnson) Newsgroups: comp.protocols.time.ntp Subject: Re: Bug in xntp version 1.3 in clock selection Message-ID: <1991Jun7.075643.11097@cl.cam.ac.uk> Date: 7 Jun 91 07:56:43 GMT References: <9106061825.AA01752@windsail.nersc.gov> Sender: news@cl.cam.ac.uk (The news facility) Distribution: inet Organization: U of Cambridge Computer Lab, UK Lines: 50