🚀 go-pugleaf

In article <1992Aug7.022422.9878@afterlife.ncsc.mil> sjr@afterlife.ncsc.mil (Stephen J. Roznowski) writes:
>Currently, the program does the following:
>
>	system("/bin/stty -echo ...");
>
>Now suppose that I do "all the correct things" before issuing the
>"system" call (set IFS, etc.) is this worse/same as the following:
>
>	tcgetattr(fd, &t);
>	t.c_lflag &= ~ECHO;
>	tcsetattr(fd, TCSANOW, &t);

Using 'system()' is a big loss security-wise.  You can easily
verify the security impact of an ioctl to turn on raw mode. However,
system() is open to SO many abuses it isn't funny.  For instance,
if PATH has '.' in it, you better hope your /bin/sh is one that
automatically resets IFS - otherwise, the guy can put a program
called 'bin' in the current directory, and nuke you - this was how
the infamous 'expreserve' hole worked - it did a 'system("/bin/mail"...)"

I'm sure the security mavens in this group can add another 5-6 different
ways to break a "system()" call.. ;)

				Valdis Kletnieks
				Computer Systems Engineer
				Virginia Tech