🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.soft-sys.andrew
Article #2014

(none)

#2014
From: Kazuhiro Kitagawa
Date: Thu, 11 Jan 1990 13:52
117 lines
3925 bytes
We ca not compile the latest relase of the ATK with X11R4 headers.
The followings are result of make and then, hc died.
The hc version is 2.1s.

hc -c -I.  -O -I/usr/andrew/include/atk -I/usr/andrew/include -I//usr/include/X11   cmcreate.c

E "cmcreate.c",L207/C10:        Type "GC" is not assignment compatible with type
 "Display*".
E "cmcreate.c",L207/C10:        Insufficient number of arguments to function.
E "cmcreate.c",L209/C10:        Type "GC" is not assignment compatible with type
 "Display*".
E "cmcreate.c",L209/C10:        Insufficient number of arguments to function.
E "cmcreate.c",L212/C14:        Type "Pixmap" is not assignment compatible with
type "Display*".
E "cmcreate.c",L212/C14:        Insufficient number of arguments to function.
6 user errors   No warnings

The followings is the lists below the line 197.
    if (dp->grayGC != NULL)
        XFreeGC(display, dp->grayGC);
    if (dp->whiteGC != NULL)
        XFreeGC(display, dp->whiteGC);
    if (dp->titleBlackGC != NULL)
        XFreeGC(display, dp->titleBlackGC);
    if (dp->blackGC != NULL)
        XFreeGC(display, dp->blackGC);
    if (dp->saveUnderGC != NULL)
        XFreeGC(dp->saveUnderGC);
    if (dp->invertGC != NULL)
        XFreeGC(dp->invertGC);

The above three lines should be
       XFreeGC(display, dp->saveUnderGC);
    if(...)
       XFreeGC(display, dp->invertGC);

And the line 212, 

 if (dp->wormIcon != NULL) /* Never happens, but here for safety when someone adds anothe
r item... */
        XFreePixmap(dp->wormIcon);

should be
        XFreePixmap(display, dp->wormIcon);


*** overhead/cmenu/cmcreate.c	Thu Jan 11 20:24:23 1990
--- overhead/cmenu/cmcreate.c.orig	Thu Jan 11 20:18:51 1990
***************
*** 204,215 ****
      if (dp->blackGC != NULL)
  	XFreeGC(display, dp->blackGC);
      if (dp->saveUnderGC != NULL)
! 	XFreeGC(display, dp->saveUnderGC);
      if (dp->invertGC != NULL)
! 	XFreeGC(display, dp->invertGC);
  
      if (dp->wormIcon != NULL) /* Never happens, but here for safety when someone adds another item... */
! 	XFreePixmap(display, dp->wormIcon);
  
      return -1;
  }
--- 204,215 ----
      if (dp->blackGC != NULL)
  	XFreeGC(display, dp->blackGC);
      if (dp->saveUnderGC != NULL)
! 	XFreeGC(dp->saveUnderGC);
      if (dp->invertGC != NULL)
! 	XFreeGC(dp->invertGC);
  
      if (dp->wormIcon != NULL) /* Never happens, but here for safety when someone adds another item... */
! 	XFreePixmap(dp->wormIcon);
  
      return -1;
  }




-------------------Next--------------------
And same bugs in cmdraw.c

*** overhead/cmenu/cmdraw.c	Thu Jan 11 20:30:13 1990
--- overhead/cmenu/cmdraw.c.orig	Thu Jan 11 20:29:37 1990
***************
*** 448,457 ****
      if (state->doSaveUnder) { /* Hair city... */
  
          Window dummyWindow;
!         unsigned int parentWidth;
!         unsigned int parentHeight;
!         unsigned int borderWidth;
!         unsigned int depth;
          int menuX;
          int menuY;
          int menuWidth = state->stackWidth;
--- 448,457 ----
      if (state->doSaveUnder) { /* Hair city... */
  
          Window dummyWindow;
!         int parentWidth;
!         int parentHeight;
!         int borderWidth;
!         int depth;
          int menuX;
          int menuY;
          int menuWidth = state->stackWidth;

     



          -kaz
           Kaz Kitagawa Phd. student
           KEIO Univ. Dept. of Math.
           Yokohama, Japan.
Technical Details
Message-ID: <9001111352.AA19600@kris.mita.keio.ac.jp>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!clyde.concordia.ca!uunet!tut.cis.ohio-state.edu!ucbvax!mita.keio.ac.jp!kaz

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!clyde.concordia.ca!uunet!tut.cis.ohio-state.edu!ucbvax!mita.keio.ac.jp!kaz
From: kaz@mita.keio.ac.jp (Kazuhiro Kitagawa)
Newsgroups: comp.soft-sys.andrew
Subject: (none)
Message-ID: <9001111352.AA19600@kris.mita.keio.ac.jp>
Date: 11 Jan 90 13:52:14 GMT
Sender: daemon@ucbvax.BERKELEY.EDU
Organization: The Internet
Lines: 117