Article View: comp.soft-sys.khoros
Article #1002journal playback & concert bug (fix)
From: Mark Young
Date: Sat, 21 Nov 1992 17:43
Date: Sat, 21 Nov 1992 17:43
48 lines
2395 bytes
2395 bytes
Hi,
First off let me say that will be the first of several messages i'll
be sending out about bugs/fixes that have been reported in the last
week. This first bug was reported by Jon Hale of Omron Corporation.
Thanks Jon for reporting and helping us fix this bug!! We really
appreciate the time and effort that you and omron invested in tracking
this down.
The bug had to do with journal playback not properly working on
certain machines. While in playback it would playback alpha-numerical
values correctly, but not for special or characters that used different
modifiers (shift, etc). On the omron when the xprism3 journal playback
would try and redisplay the keyword file:
plot3D:example3.0
It would come out as:
plot3D*example3.0
The ':' being incorrectly substituted for a '*'. The keysym record and
playback within journal playback is not correctly translating between
the different keyboards. The problem is that the journal playback
mechanism is not looking up the state as well as the keycode. Here is
the fix that should be applied:
in the file $KHOROS_HOME/src/xvroutines/Lib/xvforms/jp_playback.c on line
310 change from:
keysym = XStringToKeysym(string);
event->xkey.keycode = XKeysymToKeycode(xvf_display, keysym);
to:
keysym = XStringToKeysym(string);
event->xkey.keycode = XKeysymToKeycode(xvf_display, keysym);
if (XKeycodeToKeysym(xvf_display, event->xkey.keycode, 1) == keysym)
event->xkey.state = ShiftMask;
else
event->xkey.state = 0;
--------------------------------------------------------------------------
Mark Young young@chama.eece.unm.edu
Khoros Group (505) 277-6563 (work)
University of New Mexico Albuquerque, NM 87131
--------------------------------------------------------------------------
Humor is something that is plentyful if you are willing to laugh at yourself.
Technical Details
Message-ID:
<41776@pprg.eece.unm.edu.pprg.unm.edu>Path:
arc1-ca.pugleaf.net!sparky!uunet!dtix!darwin.sura.net!spool.mu.edu!uwm.edu!ogicse!mimbres.cs.unm.edu!pprg.unm.edu!daemonShow Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!sparky!uunet!dtix!darwin.sura.net!spool.mu.edu!uwm.edu!ogicse!mimbres.cs.unm.edu!pprg.unm.edu!daemon From: young@chama.eece.unm.edu (Mark Young) Newsgroups: comp.soft-sys.khoros Subject: journal playback & concert bug (fix) Message-ID: <41776@pprg.eece.unm.edu.pprg.unm.edu> Date: 21 Nov 92 17:43:35 GMT Sender: daemon@pprg.unm.edu Lines: 48