🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.soft-sys.khoros
Article #1004

cantata save selected glyphs bug (fix)

#1004
From: Mark Young
Date: Sat, 21 Nov 1992 18:20
60 lines
2521 bytes
This next bug is compliments of Patrick Haggard.  The problem is
that if you try and save selected glyphs the dialog filename will
not be expanded using vfullpath().  Khoros's vfullpath() routine
is responsible for file expanding "~/","~{username}","${environ}",
etc.  Following is the mail and fix sent to khoros-bugs.

		thanks,
			Mark


Hi Patrick,

On Nov 19,  7:15pm, Patrick Haggard wrote:
} Subject: Bug/feature in "save glyphs" dialog box
} From @prg.oxford.ac.uk:ph@physiology.oxford.ac.uk  Thu Nov 19 15:12:37 1992
} To: khoros-bugs@bullwinkle.eece.unm.edu
} Subject: Bug/feature in "save glyphs" dialog box
} 
} Patrick Haggard --- ph@uk.ac.ox.physiol
} 
} 	CANTATA
} Bug Description:
} ---------------
} 	When using the save glyphs item from the edit menu, you get a
} dialog box to type in a filename.  Typing "~" in this box does not get
} interpreted as $HOME.  In most dialogs (those which use the broswer) ~
} works fine. 
}-- End of excerpt from Patrick Haggard

   I looked the problem real fast and you are right.  There is a bug where
the file is not getting expanded before calling the xvl_save_workspace()
routine.  If you want to fix the problem please change the following
code on line 682 of the $KHOROS_HOME/src/xvroutines/cantata/clipboard.c

from:
        {
           xvl_save_workspace(workspace, workspace->selected, name, True);
        }

to:
        {
           char fullpath[512];
           name = vfullpath(name, NULL, fullpath);
           xvl_save_workspace(workspace, workspace->selected, name, True);
        }


			thanks for the bug report,
				Mark

ps.  i compiled this and did a quick test so there should be no side
     affects.

-----------------------------------------------------------------------------
Mark Young                         young@chama.eece.unm.edu
 
Khoros Group                       (505) 277-6563  (work)
University of New Mexico           Albuquerque,    NM 87131
-----------------------------------------------------------------------------
Humor is something that is plentyful if you are willing to laugh at yourself.
Technical Details
Message-ID: <41778@pprg.eece.unm.edu.pprg.unm.edu>
Path: arc1-ca.pugleaf.net!sparky!uunet!spool.mu.edu!uwm.edu!ogicse!mimbres.cs.unm.edu!pprg.unm.edu!daemon

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!sparky!uunet!spool.mu.edu!uwm.edu!ogicse!mimbres.cs.unm.edu!pprg.unm.edu!daemon
From: young@chama.eece.unm.edu (Mark Young)
Newsgroups: comp.soft-sys.khoros
Subject: cantata save selected glyphs bug (fix)
Message-ID: <41778@pprg.eece.unm.edu.pprg.unm.edu>
Date: 21 Nov 92 18:20:50 GMT
Article-I.D.: pprg.41778
Sender: daemon@pprg.unm.edu
Lines: 60