🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: comp.sources.bugs
Article #2172

Re: Fix for MIT Athena delete/undelete programs

#2172
From: Jonathan I. Kamens
Date: Fri, 07 Apr 1989 03:43
53 lines
2908 bytes
In article <4479@drivax.UUCP> davison@drivax.UUCP (Wayne Davison) writes:
>   The following patch file fixes two bugs in the MIT Athena
>   delete/undelete posting in comp.sources.unix and makes one
>   usability change to expunge.c.

Thank you for the input and the fixes.  They are all valid.

>   The first bug is a problem in col.c when using an auto-wrap
>   terminal.  If the columns divide evenly into 80, the last one will
>   be space-padded up to the 80th character, causing a screen wrap and
>   double-spaced output.  The fix is to not space-pad the last column
>   on a line.

Accepted in full and will go out again in the next official
patch/release (if there is another one :-).

>   The second bug is more serious.  When you specify a minimum time
>   for expunge and it skips a file because it is not old enough to
>   expunge, it decreases the number of found files.  This causes the
>   loop to terminate before processing all of the files, skipping the
>   ones at the end of the list.  I fixed this by adding a count of
>   skipped files, and subtracting it off the found count for the
>   return value.

Ditto.

>   Finally, I changed the way purge is handled in expunge to enable
>   the processing of options such as `-t2' or a directory name.  The
>   purge functionality can now be accessed either with the `-p' option
>   of expunge, or through the `purge' file link created by the
>   Makefile.

I can't install this in our sources.  After a long and drawn-out
design process, it was decided here at Athena that purge should be
*only* a purge, and should not take command-line arguments.  The
purpose of the purge command is to give our users a very simple
command they can type that they can be sure will get rid of the
deleted files in their home directory if they are over quota and need
to do something about it.

You can leave your patch in your version of the sources, but I can't
put it into ours.  It's a valid patch if it's the functionality you
want, but it's not what we want here :-)

>					   ..Wayne..

Jonathan Kamens			              USnail:
MIT Project Athena				410 Memorial Drive, No. 223F
jik@Athena.MIT.EDU				Cambridge, MA 02139-4318
Office: 617-253-4261			      Home: 617-225-8218

P.S. Now, if you had submitted a man page patch for expunge and purge
as well, I might have thought about installing it :-)
Technical Details
Message-ID: <10382@bloom-beacon.MIT.EDU>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!tut.cis.ohio-state.edu!bloom-beacon!athena.mit.edu!jik
References: <4479@drivax.UUCP>

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!tut.cis.ohio-state.edu!bloom-beacon!athena.mit.edu!jik
From: jik@athena.mit.edu (Jonathan I. Kamens)
Newsgroups: comp.sources.bugs
Subject: Re: Fix for MIT Athena delete/undelete programs
Message-ID: <10382@bloom-beacon.MIT.EDU>
Date: 7 Apr 89 03:43:48 GMT
References: <4479@drivax.UUCP>
Sender: daemon@bloom-beacon.MIT.EDU
Reply-To: jik@athena.mit.edu (Jonathan I. Kamens)
Organization: Massachusetts Institute of Technology
Lines: 53