🚀 go-pugleaf

In article <10632@cup.portal.com> thad@cup.portal.com (Thad P Floryan) writes:
>Extracted fragment:
>          struct FileInfoBlock *fib;
>
>          fib = AllocMem((long)sizeof(fib), 1L);
>
>Should be:
>   fib = (struct FileInfoBlock *)
>              AllocMem((long)sizeof(struct FileInfoBlock), MEMF_CLEAR);
>                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Actually,

extern void *AllocMem();

prevents your having to cast its return value, but, I think, it is a MANXism.
And,

	fib = AllocMem ((long)sizeof(*fib), MEMF_CLEAR);
                                     ^<--- sizeof what fib points to

would have been perfectly good C code, and a handy typing and thinking
shortcut I use all the time.
But I agree that MEMF_whatever should be used instead of the constant.


-- 
Guy Streeter
...uunet!ingr!b11!guy		(UUCP)
ingr!b11!guy@uunet.uu.net	(ARPANET)