🚀 go-pugleaf

Russ Allbery <rra@stanford.edu> writes:

>ISO C9x, which I was just reading earlier today, actually specifies a new
>structure, struct tmx,

struct tmx was in early drafts of ISO C9x, but the spec had a lot of
problems that were uncovered during review, and struct tmx was removed
before C99 became official.  struct tmx shouldn't be used in real code.

>the code that you included uses timezone if tm_gmtoff isn't available.
>INN falls back on calling localtime and gmtime and comparing them.

INN's method is more reliable.  The problem with the 'timezone' method
is that it assumes that standard time has a fixed UTC offset.  This
assumption is incorrect.  E.g. Argentina changed their standard-time
UTC offset last month.  Perhaps the PHP 'timezone' code with could be
fixed to work in most cases, but it's certainly not guaranteed to work
and I would suggest that it remove all references to 'timezone'.

I should point out that I helped to write and debug that part of the
INN code, so I'm not unbiased here.