🚀 go-pugleaf

On 2006-07-11, kvnsmnsn@hotmail.com wrote:
> I'm trying to build a bash script that creates an "x.java" and a
> "y.java" file from three existing pairs of files, depending on whether
> an "a", a "b", or a "c" is entered on the command line.  My bash code
> checks to see if the number of arguments entered on the command line
> is one, which check it handles fine, but if it passes that check and
> goes on to the next "if" statement, it gives me the complaints:
>
>      Hmm.sh: line 4: [: missing `]'
>      Hmm.sh: line 4: a: command not found
>      Hmm.sh: line 4: a: command not found
>      Incorrect operand "a".
>
> My actual code is:
>
>      #! /bin/sh
>      if [ $# == 1 ]
>      then
>        if [ $1 == "a" || $1 == "b" || $1 == "c" ]

if [ $1 == "a" ] || [ $1 == "b" ] || [ $1 == "c" ]

   Or:

if [ $1 == "a" -o $1 == "b" -o $1 == "c" ]

>        then
>          cp x_$1.java x.java
>          cp y_$1.java y.java
>        else
>          echo "Incorrect operand \"$1\"."
>        fi
>      else
>        echo "Usage is"
>        echo "  sh Hmm.sh <suffix>"
>      fi
>
> Can anyone see what I'm doing wrong here?  Any pointers would be
> greatly appreciated.

    Simpler is a case statement:

case $1 in
     a|b|c) cp x_$1.java x.java
            cp y_$1.java y.java
            ;;
     *? ) echo "Incorrect operand \"$1\"."
          ;;
     *) echo "Usage is"
        echo "  sh Hmm.sh <suffix>"
        ;;
esac

-- 
   Chris F.A. Johnson, author              <http://cfaj.freeshell.org>
   Shell Scripting Recipes: A Problem-Solution Approach (2005, Apress)
   ===== My code in this post, if any, assumes the POSIX locale
   ===== and is released under the GNU General Public Licence