🚀 go-pugleaf

   I have done the same bug fix to UWM to prevent it from stealing button
combinations from applications just to get that button over the root
window.  The change is simple, mainly in uwm.c, but in Menu, Move,
MoveOpaque, NewIconify, and Resize all calls to XGrabButton and Grab must
be replaced by XGrabMouse and XUngrabMouse.

   On window manager architectures, I believe that

   1. X default user interface policies need to be better thought out and
agreed on.

   2. Willy-nilly expansion of chording, multiple clicks, and other
complex ways to give selection input will make X user interfaces
impenetrable.  Therefore making 1. happen is imperative.

   2. A separate window manager process is necessary to use the V11
facilities to pull inconsistent application mouse usages into consistency
(via sending events) and the give users control of their user interfaces.
But the overhead of this redirection means it needs to be used sparingly,
therefore 1. is still necessary.

   3. An "external model" UI that owns the V11 widgets for integrated
applications is the way to go.  How this piece plays with the window
manager is an interesting architectural question.

-----------
692a693
> 	char NeedRootInput=1;
695c696,713
<         Grab(bptr->mask);
---
> 	    if ((bptr->context & (WINDOW | ICON | ROOT)) == ROOT)
> 		/* don't grab buttons if you don't have to - allow application 
> 		access to buttons unless context includes window or icon
> 		The rest of uwm must be careful to only use GrabMouse! */
> 		{
> 			/* instead, select input on the root window */
> 			if(NeedRootInput)
> 			{
> 				XSelectInput(RootWindow, EVENTMASK);
> 				NeedRootInput = 0;
> 			}
> 		}
> 		else
> 		{
> 			/* context includes a window, so must grab */
> 	        Grab(bptr->mask);
> 		}
> 
-----------------------
< old Move, > new Move
2c2
< static char *rcsid_Move_c = "$Header: Move.c,v 1.3 87/01/23 07:56:03 glennw Exp $";
---
> static char *rcsid_Move_c = "$Header: Move.c,v 1.4 87/02/10 13:25:45 glennw Exp $";
72c72
<      * Change the cursor.
---
>      * Change the cursor and grab the mouse even if button already down.
74c74,75
<     status = XGrabButton(RootWindow, ArrowCrossCursor, mask, EVENTMASK);
---
>     status = XGrabMouse(RootWindow, ArrowCrossCursor, EVENTMASK);
> 
76c77
<         Error("Move -> Unable to grab button and change cursor.");
---
>         Error("Move -> Unable to grab mouse and change cursor.");
166c167
<                 Grab(mask);
---
>                 XUngrabMouse(mask);
190c191
<                 Grab(mask);
---
>                 XUngrabMouse(mask);

-- 
Glenn Widener