🚀 go-pugleaf

I've just tracked down a bug in KA9Q.

Symptoms:

    Try to list the dns cache with the command:

        domain cache list

    At this point, the OS/2 version of KA9Q crashes with a SYS3175 access
    violation.

Explanation:

    The docachelist() function in domain.c calls newsession() to create a
    separate "session window" to display the cache listing. 

        static int docachelist(int argc, char *argv[], void *p)
        {
            struct rr *rrp;
            struct session *sp;
            int row;
        
            if((sp = newsession(argv[1],DCLIST)) == NULLSESSION)
            {
                return -1;
            }

    The "dns cache list" command takes no further parameters, so only
    argv[0] is defined - argv[1] is undefined/NULL.

Fix:

    Pass argv[0] to newsession() instead:

        static int docachelist(int argc, char *argv[], void *p)
        {
            struct rr *rrp;
            struct session *sp;
            int row;
        
            if((sp = newsession(argv[0],DCLIST)) == NULLSESSION)
            {
                return -1;
            }

This bug hasn't yet crashed the DOS implementation of KA9Q 2.16d in a DOS
session on my machine, but we know that DOS is quite happy to let
programs read NULL pointers.
 
Niel
-- 
Dr C Niel Kempson
Snowy Owl Systems Limited
E-mail: kempson@snowyowl.co.uk (Internet)