🚀 go-pugleaf

Brian {Hamilton Kelly} <bhk@dsl.co.uk> wrote:
>In article <838400731snz@dsl.co.uk>
>           bhk@dsl.co.uk "Brian {Hamilton Kelly}" writes:

>> On the basis that there were almost 120 times as many expired items as
>> those that weren't, and that there was no other "corruption" of the file,

Eek!  I can just imagine the number of KA9Q/2 users with *huge* 
DOMAIN.TXTs out there, all wondering why they only ever connected to 
one of the newsservers ...

>The TTL field is certainly *used* as if it were, as Graham, says, a
>signed 32-bit integer (from DOMAIN.C):

>Well, let's look at the definition of int32 (from GLOBAL.H):
>    typedef unsigned long int32;    /* 32-bit signed integer */

Ah, I haven't got the full OS/2 source unzipped, didn't think to check 
it that closely, I only went through DOMAIN.C looking for obvious sign 
problems.  From the Dos GLOBAL.H:

     typedef long int32;             /* 32-bit signed integer */

>The reason why I say it will be difficult
>to fix is that there are literally hundreds of variables declared as
>int32s: some of these may be meant to be signed, and some unsigned, and
>the code involving each will have to be examined to determine which is
>which.  I've counted 429 lines in the sources which mention int32, and
>that's without looking at the OS/2 specific files!

:-(  I found similar problems fixing all the warnings to compile the 
Dos version under Borland v4; it's (quite rightly) much stricter about 
32bit types and there were a few places where int32, long, unsigned 
long and even int were used interchangeably.  I suspect most of them 
should be signed, based on the Dos version, but since the OS/2 source 
has been reformatted so nicely, it's difficult to check ...

Cheers, Graham.
-- 
----[ Graham E. Kinns ]----==========----< Graham@grempc.demon.co.uk >----