Readline bug

Thread View: gnu.bash.bug

2 messages

[T] Back to Threads [V] Tree View [G] Group Articles

2 total messages Started by bothner Mon, 15 Jan 1990 23:27

#836

Author: bothner
Date: Mon, 15 Jan 1990 23:27

29 lines
1294 bytes

Just in case this bug has not already been reported ...
The start_insert function in readline/readline.c
is broken for terminal descriptors that support
both im (insert mode) and IC/ic (insert characters)
(such as Xterm) - the function inserts extra
spaces AS WELL as entering insert mode.
This trivial fix seems to work.
	--Per Bothner

*** readline.c~	Sat Nov  4 07:42:01 1989
--- readline.c	Mon Jan 15 14:20:53 1990
***************
*** 1892,1899 ****
  {
    if (term_im && *term_im)
      tputs (term_im, 1, output_character_function);
! 
!   if (term_IC && *term_IC &&
        (count > 1 || !term_ic || !*term_ic))
      {
        char *tgoto (), *buffer;
--- 1892,1898 ----
  {
    if (term_im && *term_im)
      tputs (term_im, 1, output_character_function);
!   else if (term_IC && *term_IC &&
        (count > 1 || !term_ic || !*term_ic))
      {
        char *tgoto (), *buffer;

Re: Readline bug

#847

Author: News system owner ID
Date: Fri, 19 Jan 1990 22:51

15 lines
1009 bytes

bothner@CS.WISC.EDU writes:

>Just in case this bug has not already been reported ...
>The start_insert function in readline/readline.c
>is broken for terminal descriptors that support
>both im (insert mode) and IC/ic (insert characters)

This is fixed in the stuff I sent to Brian.  An important caveat for
all you avid termcap terminal description writers (like me): do NOT
include both im/ei and ic UNLESS you must be in INSERT MODE to do
INSERT CHARACTER, otherwize anything that uses RMS's algorithm (like
emacs or the new readline code I sent Brian) will work wrong!!!

		-- Paul Placeway
		   <pplaceway@bbn.com>

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads