🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #100038

emacs 18.55 x11term.c: type classes in X event calls

#100038
From: "Jonathan I. Kamens"
Date: Wed, 14 Mar 1990 08:16
49 lines
2096 bytes
  The file x11term.c in the emacs 18.55 sources makes calles to
XRefreshKeyboardMapping() and XLookupString() and passes an argument
of the wrong type; your compiler probably won't complain unless you're
using one with prototypes and compiling against x11r4; furthermore,
it'll probably work even without this patch.  However, "formally" this
patch should be applied, and the problem may just bite somebody.

Jonathan Kamens			              USnail:
MIT Project Athena				11 Ashford Terrace
jik@Athena.MIT.EDU				Allston, MA  02134
Office: 617-253-8495			      Home: 617-782-0710

*** /tmp/,RCSt1028412	Wed Mar 14 03:15:11 1990
--- x11term.c	Wed Mar 14 03:11:06 1990
***************
*** 1245,1251 ****
        break;
  
      case MappingNotify:
!       XRefreshKeyboardMapping(&event);
        break;
  
      case MapNotify:
--- 1245,1251 ----
        break;
  
      case MappingNotify:
!       XRefreshKeyboardMapping(&event.xmapping);
        break;
  
      case MapNotify:
***************
*** 1321,1327 ****
        break;
  
      case KeyPress:
!       nbytes = XLookupString (&event,
  			      mapping_buf, 20, &keysym,
  			      0);
        /* Someday this will be unnecessary as we will
--- 1321,1327 ----
        break;
  
      case KeyPress:
!       nbytes = XLookupString (&event.xkey,
  			      mapping_buf, 20, &keysym,
  			      0);
        /* Someday this will be unnecessary as we will
Technical Details
Message-ID: <9003140816.AA28417@pit-manager.MIT.EDU>
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!bu.edu!ncsuvx!mephisto!tut.cis.ohio-state.edu!PIT-MANAGER.MIT.EDU!jik

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,bfad44334e96bbb,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1990-03-14 00:16:16 PST
Path: arc1-ca.pugleaf.net!gmdzi!unido!mcsun!uunet!bu.edu!ncsuvx!mephisto!tut.cis.ohio-state.edu!PIT-MANAGER.MIT.EDU!jik
From: jik@PIT-MANAGER.MIT.EDU ("Jonathan I. Kamens")
Newsgroups: gnu.emacs.bug
Subject: emacs 18.55 x11term.c: type classes in X event calls
Message-ID: <9003140816.AA28417@pit-manager.MIT.EDU>
Date: 14 Mar 90 08:16:16 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 49
Posted: Wed Mar 14 09:16:16 1990