🚀 go-pugleaf

In GNU Emacs 19.27.1 (sparc-sun-sunos4.1.3, X toolkit) of Fri Sep 16 1994 on jacobi

Hi there,

A user here was having problems with query-replace and
tags-query-replace. I looked at it and found that in perform-replace
(replace.el) there is code to change the markers in the match-data
back to numbers. The function that does it does not check whether
it is passed a marker and sometimes tries to get the call
marker-position on a number. This fails. I could not reproduce this
in my environment but that was reproducible in his (which uses
hilit19, hence has lots of text properties around the buffers onto
which the query-replace function was called).  

(match-data) is documented as possibly returning a list of markers or
a list of numbers. 

It looks to me like 

-----
	      ;; Record previous position for ^ when we move on.
	      ;; Change markers to numbers in the match data
	      ;; since lots of markers slow down editing.
	      (setq stack
		    (cons (cons (point)
				(or replaced
				    (mapcar (lambda (elt)
					      (and elt
						   (prog1 (marker-position elt)
						     (set-marker elt nil))))
				     (match-data))))
			  stack))
-----------
near the end of perform-replace could be changed to
	      ;; Record previous position for ^ when we move on.
	      ;; Change markers to numbers in the match data
	      ;; since lots of markers slow down editing.
	      (setq stack
		    (cons (cons (point)
				(or replaced
				    (mapcar (lambda (elt)
                                              (if (numberp elt)
						 elt
	                                       ;; nil or marker
					      (and elt
						   (prog1 (marker-position elt)
						     (set-marker elt nil)))))
				     (match-data))))
			  stack))

with a check on numberp or markerp on elt.

Regards,

Dominique
-- 
Dominique de Waleffe            ddw@sunbim.be
BIM sa
Chaussee de Louvain, 510	Tel: +32 2 719 26 14
B-1930 Zaventem			Fax: +32 2 725 47 83
Belgium				PGP-Public-Key available on request