🚀 go-pugleaf

Emacs 19.26.

add-log.el cannot be dumped, because (eg) add-log-full-name references
something not known at dump time.

Incidentally, I think that (user-full-name) should throw an error
before dumping.  That would make problems like this easier to spot.
If there are other functions that cannot be evaluated before dumping,
they should also throw errors.

Appended is a patch to add-log.el that removes the dependencies, so
add-log can now be dumped.  Here is a ChangeLog entry:

Wed Sep 21 21:26:21 1994  Tom Tromey  <tromey@drip.colorado.edu>

	* add-log.el (add-change-log-entry): Set add-log-full-name and
	  add-log-mailing-address here.
	  (add-log-full-name): Initialize to nil.
	  (add-log-mailing-address): Ditto.

Tom
---
tromey@busco.lanl.gov             Member, League for Programming Freedom
Be regular and orderly in your life like a bourgeois, so that you
may be violent and original in your work
	-- Flaubert

*** add-log.el.~1~	Sat Jul 23 20:47:18 1994
--- add-log.el	Wed Sep 21 21:29:08 1994
***************
*** 33,51 ****
    "\
  *If non-nil, function to guess name of current function from surrounding text.
  \\[add-change-log-entry] calls this function (if nil, `add-log-current-defun'
  instead) with no arguments.  It returns a string or nil if it cannot guess.")
  
! ;; This MUST not be autoloaded, since user-login-name
! ;; cannot be known at Emacs dump time.
! (defvar add-log-full-name (user-full-name)
    "*Full name of user, for inclusion in ChangeLog daily headers.
  This defaults to the value returned by the `user-full-name' function.")
  
! ;; This MUST not be autoloaded, since user-login-name
! ;; cannot be known at Emacs dump time.
! (defvar add-log-mailing-address user-mail-address
    "*Electronic mail address of user, for inclusion in ChangeLog daily headers.
  This defaults to the value of `user-mail-address'.")
  
  (defun change-log-name ()
    (or change-log-default-name
--- 33,47 ----
    "\
  *If non-nil, function to guess name of current function from surrounding text.
  \\[add-change-log-entry] calls this function (if nil, `add-log-current-defun'
  instead) with no arguments.  It returns a string or nil if it cannot guess.")
  
! (defvar add-log-full-name nil
    "*Full name of user, for inclusion in ChangeLog daily headers.
  This defaults to the value returned by the `user-full-name' function.")
  
! (defvar add-log-mailing-address nil
    "*Electronic mail address of user, for inclusion in ChangeLog daily headers.
  This defaults to the value of `user-mail-address'.")
  
  (defun change-log-name ()
    (or change-log-default-name
***************
*** 131,140 ****
--- 127,140 ----
  	 ;; full name which look silly when inserted.  Rather than do
  	 ;; anything about that here, let user give prefix argument so that
  	 ;; s/he can edit the full name field in prompter if s/he wants.
  	(setq add-log-mailing-address
  	      (read-input "Mailing address: " add-log-mailing-address))))
+   (or add-log-full-name
+       (setq add-log-full-name (user-full-name)))
+   (or add-log-mailing-address
+       (setq add-log-mailing-address user-mail-address))
    (let ((defun (funcall (or add-log-current-defun-function
  			    'add-log-current-defun)))
  	paragraph-end entry)
  
      (setq file-name (expand-file-name (find-change-log file-name)))