🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #87572

bug in forms.el and patch

#87572
From: F.Pierresteguy
Date: Wed, 14 Sep 1994 10:03
46 lines
2299 bytes
Context: I'm editing a record in forms-edit-mode. Then I switch to
forms-ro-mode without saving via M-x forms-toggle-read-only. Also I've
previously define a hook function for read-file-filter (which is
therefore non-nil).

Now I'm in view mode and I try to save via M-x forms-save-buffer.
=> Emacs says: (No changes need to be saved)
and therefore doesn't save the data which indeed has been modified and
need to be saved.

The following patch fixes this problem.

Tue Sep 13 00:14:20 1994  Fred Pierresteguy <F.Pierresteguy@frcl.bull.fr>

	* forms.el (forms-mode): When read-file-filter is non-nil, don't 
	set buffer-modified-p to nil if the buffer was previously
	modified.

===================================================================
RCS file: /triton/GNU.rep/emacs19/lisp/forms.el,v
retrieving revision 1.3
diff -p -c -r1.3 forms.el
*** 1.3	1994/08/30 15:19:47
--- forms.el	1994/09/14 08:46:33
*************** Commands:                        Equival
*** 603,611 ****
      (if read-file-filter
  	(save-excursion
  	  (set-buffer forms--file-buffer)
! 	  (let ((inhibit-read-only t))
! 	    (run-hooks 'read-file-filter))
! 	  (set-buffer-modified-p nil)
  	  (if write-file-filter
  	      (progn
  		(make-variable-buffer-local 'local-write-file-hooks)
--- 603,612 ----
      (if read-file-filter
  	(save-excursion
  	  (set-buffer forms--file-buffer)
! 	  (let ((inhibit-read-only t)
! 		(file-modified (buffer-modified-p)))
! 	    (run-hooks 'read-file-filter)
! 	    (if (not file-modified) (set-buffer-modified-p nil)))
  	  (if write-file-filter
  	      (progn
  		(make-variable-buffer-local 'local-write-file-hooks)
Technical Details
Message-ID: <9409140919.AA17216@papayer>
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!uunet!cis.ohio-state.edu!frcl.bull.FR!F.Pierresteguy

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,e68a39fd237b185,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-09-15 02:19:46 PST
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!uunet!cis.ohio-state.edu!frcl.bull.FR!F.Pierresteguy
From: F.Pierresteguy@frcl.bull.FR
Newsgroups: gnu.emacs.bug
Subject: bug in forms.el and patch
Date: 14 Sep 1994 06:03:56 -0400
Organization: GNUs Not Usenet
Lines: 46
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <9409140919.AA17216@papayer>
Reply-To: F.Pierresteguy@frcl.bull.fr