url-write-global-history bug in W3-package (+ patch)

Article View: gnu.emacs.bug

Article #87581

#87581

From: Tommi Raita-aho
Date: Thu, 15 Sep 1994 10:48

39 lines
2241 bytes

I found bug in w3 package (WWW 2.1.58, URL 1.91, MM 1.29) in file url.el

This bug causes xmosaic to misunderstand global-history-file after used
w3 with url-keep-history 't. The reason is that visited nodes
are added incorrectly at the start of the history file, not at the end
of the file. The function is url-write-global-history. Here are the
patch:

 
*** url.el      Thu Sep 15 12:56:33 1994
--- url.el.orig Tue Sep 13 11:56:56 1994
*************** then return the basename of the file wit
*** 3799,3805 ****
        (goto-char (point-min))
        (if (not (re-search-forward (regexp-quote url) nil t))
            (progn
!             (goto-char (point-max))
              (insert (concat url " " (current-time-string) "\n"))))))
       url-history-list))
    (write-file url-global-history-file)
--- 3799,3805 ----
        (goto-char (point-min))
        (if (not (re-search-forward (regexp-quote url) nil t))
            (progn
!             (goto-char (point-min))
              (insert (concat url " " (current-time-string) "\n"))))))
       url-history-list))
    (write-file url-global-history-file)



- TRa

--
  <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
  <>  Tommi Raita-aho   tra@lenkkari.cs.tut.fi                    <>
  <a  href= "http://lenkkari.cs.tut.fi/~tra/" >    WWW Home Page</a>
  <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>

Technical Details

Message-ID: <TRA.94Sep15134047@varvikas.cs.tut.fi>

Path:

arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!redstone.interpath.net!ddsw1!news.kei.com!MathWorks.Com!europa.eng.gtefsd.com!howland.reston.ans.net!usenet.ins.cwru.edu!magnus.acs.ohio-state.edu!cis.ohio-state.edu!varvikas.cs.tut.fi!tra

Show Full Headers

Complete Article Headers

X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,ea2e6498e9dedd38,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-09-15 08:52:42 PST
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!redstone.interpath.net!ddsw1!news.kei.com!MathWorks.Com!europa.eng.gtefsd.com!howland.reston.ans.net!usenet.ins.cwru.edu!magnus.acs.ohio-state.edu!cis.ohio-state.edu!varvikas.cs.tut.fi!tra
From: tra@varvikas.cs.tut.fi (Tommi Raita-aho)
Newsgroups: gnu.emacs.bug
Subject: url-write-global-history bug in W3-package (+ patch)
Date: 15 Sep 1994 06:48:22 -0400
Organization: Signal Proc. Lab, Tampere Univ. of Technology, Finland
Lines: 39
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <TRA.94Sep15134047@varvikas.cs.tut.fi>