Article View: gnu.emacs.bug
Article #87661A bug in dispnew.c: preserve_other_columns()
From: Jukka Partanen
Date: Thu, 08 Sep 1994 11:24
Date: Thu, 08 Sep 1994 11:24
69 lines
3363 bytes
3363 bytes
Emacs version: GNU Emacs 19.25.95 Here's a fix for a bug which manifests itself when split-window-horizontally is used on a machine where sizeof (int) != sizeof (pointer), eg. alpha. This results in a garbled display when using motion commands. The reason is that too many glyphs are copied from the other window(s) to desired_frame->glyphs[vpos]. I know the alpha isn't officially supported, but the bug should still be fixed. Regards, jtp HELLO KITTY gang terrorizes town, family STICKERED to death! *** dispnew.c.orig Tue Sep 6 18:36:11 1994 --- dispnew.c Thu Sep 8 13:51:41 1994 *************** preserve_other_columns (w) *** 851,860 **** bcopy (current_frame->glyphs[vpos], desired_frame->glyphs[vpos], ! start * sizeof (current_frame->glyphs[vpos])); bcopy (current_frame->charstarts[vpos], desired_frame->charstarts[vpos], ! start * sizeof (current_frame->charstarts[vpos])); len = min (start, current_frame->used[vpos]); if (desired_frame->used[vpos] < len) desired_frame->used[vpos] = len; --- 851,860 ---- bcopy (current_frame->glyphs[vpos], desired_frame->glyphs[vpos], ! start * sizeof (current_frame->glyphs[vpos][0])); bcopy (current_frame->charstarts[vpos], desired_frame->charstarts[vpos], ! start * sizeof (current_frame->charstarts[vpos][0])); len = min (start, current_frame->used[vpos]); if (desired_frame->used[vpos] < len) desired_frame->used[vpos] = len; *************** preserve_other_columns (w) *** 871,881 **** bcopy (current_frame->glyphs[vpos] + end, desired_frame->glyphs[vpos] + end, ((current_frame->used[vpos] - end) ! * sizeof (current_frame->glyphs[vpos]))); bcopy (current_frame->charstarts[vpos] + end, desired_frame->charstarts[vpos] + end, ((current_frame->used[vpos] - end) ! * sizeof (current_frame->charstarts[vpos]))); desired_frame->used[vpos] = current_frame->used[vpos]; } } --- 871,881 ---- bcopy (current_frame->glyphs[vpos] + end, desired_frame->glyphs[vpos] + end, ((current_frame->used[vpos] - end) ! * sizeof (current_frame->glyphs[vpos][0]))); bcopy (current_frame->charstarts[vpos] + end, desired_frame->charstarts[vpos] + end, ((current_frame->used[vpos] - end) ! * sizeof (current_frame->charstarts[vpos][0]))); desired_frame->used[vpos] = current_frame->used[vpos]; } }
Technical Details
Message-ID:
<9409081122.AA07961@kitt.tekla.fi.tekla.fi>Path:
arc1-ca.pugleaf.net!nntp.gmd.de!xlink.net!slsv6bt!slbh01.bln.sel.alcatel.de!rcvie!Austria.EU.net!EU.net!howland.reston.ans.net!vixen.cso.uiuc.edu!sdd.hp.com!col.hp.com!csn!rutgers!cis.ohio-state.edu!tekla.FI!jtpShow Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit X-Google-Thread: fb2f1,caf4f482838e171,start X-Google-Attributes: gidfb2f1,public X-Google-ArrivalTime: 1994-09-08 19:11:04 PST Path: arc1-ca.pugleaf.net!nntp.gmd.de!xlink.net!slsv6bt!slbh01.bln.sel.alcatel.de!rcvie!Austria.EU.net!EU.net!howland.reston.ans.net!vixen.cso.uiuc.edu!sdd.hp.com!col.hp.com!csn!rutgers!cis.ohio-state.edu!tekla.FI!jtp From: jtp@tekla.FI (Jukka Partanen) Newsgroups: gnu.emacs.bug Subject: A bug in dispnew.c: preserve_other_columns() Date: 8 Sep 1994 07:24:51 -0400 Organization: GNUs Not Usenet Lines: 69 Sender: daemon@cis.ohio-state.edu Approved: bug-gnu-emacs@prep.ai.mit.edu Distribution: gnu Message-ID: <9409081122.AA07961@kitt.tekla.fi.tekla.fi>