🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #87670

Bug in 19.26 version of vc.el

#87670
From: Andy Yule
Date: Thu, 08 Sep 1994 17:22
47 lines
3016 bytes
In GNU Emacs 19.26.2 (sparc-sun-sunos4.1.3, X toolkit) of Thu Sep  8 1994 on prsun7

The latest (19.26) version of vc.el behaves slightly differently when
checking out an SCCS controlled file.  In particular, the following
change to vc-backend-checkout (when compared to 19.25) causes
vc-version-other-window to fail if vc-path is relied on:

1514,1517c1527,1550
<      (vc-do-command 0 "get" file      ;; SCCS
<                   (if writable "-e")
<                   (if workfile  (concat "-G" workfile))
<                   (and rev (concat "-r" (vc-lookup-triple file rev))))
---
>      (if workfile ;; SCCS
>        ;; Some SCCS implementations allow checking out directly to a
>        ;; file using the -G option, but then some don't so use the
>        ;; least common denominator approach and use the -p option
>        ;; ala RCS.
>        (let ((vc-modes (logior (file-modes (vc-name file))
>                                (if writable 128 0)))
>              (failed t))
>          (unwind-protect
>              (progn
>                  (vc-do-command
>                     0 "/bin/sh" file "-c"
>                     (format "umask %o; exec >\"$1\" || exit; shift; umask %o; exec get \"$@\""
>                             (logand 511 (lognot vc-modes))
>                             (logand 511 (lognot (default-file-modes))))
>                     "" ; dummy argument for shell's $0
>                     filename 
>                     (if writable "-e")
>                     "-p" (and rev (concat "-r" (vc-lookup-triple file rev))))
>                  (setq failed nil))
>            (and failed (file-exists-p filename) (delete-file filename))))
>        (vc-do-command 0 "get" file    ;; SCCS
>                     (if writable "-e")
>                     (and rev (concat "-r" (vc-lookup-triple file rev)))))

The problem occurs if the SCCS command "get" is not in the default
search path, but is added by means to the variable vc-path.  In this
case the vc-do-command that uses /bin/sh fails, as it effectively
ignores the setting of vc-path and so can't find "get".

                              Andy Yule

------------------------------------------------------------------------
yuleat@prl.philips.co.uk    ------    Philips Research Labs, Redhill, UK
Technical Details
Message-ID: <28902.9409081715@prsun7.prl.philips.co.uk>
Path: arc1-ca.pugleaf.net!nntp.gmd.de!xlink.net!slsv6bt!slbh01.bln.sel.alcatel.de!rcvie!Austria.EU.net!EU.net!howland.reston.ans.net!math.ohio-state.edu!cis.ohio-state.edu!prl.PHilips.co.UK!yuleat

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,572abeac09a03e4,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-09-09 01:02:23 PST
Path: arc1-ca.pugleaf.net!nntp.gmd.de!xlink.net!slsv6bt!slbh01.bln.sel.alcatel.de!rcvie!Austria.EU.net!EU.net!howland.reston.ans.net!math.ohio-state.edu!cis.ohio-state.edu!prl.PHilips.co.UK!yuleat
From: yuleat@prl.PHilips.co.UK (Andy Yule)
Newsgroups: gnu.emacs.bug
Subject: Bug in 19.26 version of vc.el
Date: 8 Sep 1994 13:22:48 -0400
Organization: GNUs Not Usenet
Lines: 47
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <28902.9409081715@prsun7.prl.philips.co.uk>