🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #87957

fix to my earlier patch for comint completion in minibuffer

#87957
From: Jonathan I. Kamens
Date: Thu, 18 Aug 1994 01:35
43 lines
2599 bytes
In GNU Emacs 19.25.3 of Sun Aug 14 1994 on gza-client1 (sparc-sun-sunos4.1.3)

The patch I sent in earlier today for comint completion in the
minibuffer has a problem -- it doesn't display error messages in the
minibuffer when no completions are available.  It should.  This patch
fixes that.

*** comint.el	1994/08/17 15:37:12	1.2
--- comint.el	1994/08/18 01:29:28
***************
*** 1856,1862 ****
  	 (directory (if pathdir (comint-directory pathdir) default-directory))
  	 (completion (file-name-completion pathnondir directory)))
      (cond ((null completion)
!            (comint-message-inactive-minibuffer "No completions of %s" filename)
  	   (setq success nil))
            ((eq completion t)            ; Means already completed "file".
             (if comint-completion-addsuffix (insert " "))
--- 1856,1862 ----
  	 (directory (if pathdir (comint-directory pathdir) default-directory))
  	 (completion (file-name-completion pathnondir directory)))
      (cond ((null completion)
!            (message "No completions of %s" filename)
  	   (setq success nil))
            ((eq completion t)            ; Means already completed "file".
             (if comint-completion-addsuffix (insert " "))
***************
*** 1959,1965 ****
  	 (completions (file-name-all-completions pathnondir directory)))
      (if completions
  	(comint-dynamic-list-completions completions)
!       (comint-message-inactive-minibuffer "No completions of %s" filename))))
  
  
  (defun comint-dynamic-list-completions (completions)
--- 1959,1965 ----
  	 (completions (file-name-all-completions pathnondir directory)))
      (if completions
  	(comint-dynamic-list-completions completions)
!       (message "No completions of %s" filename))))
  
  
  (defun comint-dynamic-list-completions (completions)
Technical Details
Message-ID: <199408180135.VAA19891@gza-client1.aktis.com>
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!uunet!newsfeed.ACO.net!news.sztaki.hu!EU.net!howland.reston.ans.net!europa.eng.gtefsd.com!MathWorks.Com!news.cic.net!magnus.acs.ohio-state.edu!cis.ohio-state.edu!cam.ov.COM!jik

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,dfbf0b155497686c,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-08-17 18:49:12 PST
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!uunet!newsfeed.ACO.net!news.sztaki.hu!EU.net!howland.reston.ans.net!europa.eng.gtefsd.com!MathWorks.Com!news.cic.net!magnus.acs.ohio-state.edu!cis.ohio-state.edu!cam.ov.COM!jik
From: jik@cam.ov.COM (Jonathan I. Kamens)
Newsgroups: gnu.emacs.bug
Subject: fix to my earlier patch for comint completion in minibuffer
Date: 17 Aug 1994 21:35:22 -0400
Organization: GNUs Not Usenet
Lines: 43
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <199408180135.VAA19891@gza-client1.aktis.com>