🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.emacs.bug
Article #88005

completing-read doc string mentions try-completion bug not all-completions

#88005
From: Jonathan I. Kamens
Date: Sat, 13 Aug 1994 03:26
43 lines
2876 bytes
In GNU Emacs 19.25.2 of Fri Aug 12 1994 on gza-client1 (sparc-sun-sunos4.1.3)

       The documentation string for the completing function says,
"See `try-completion' for more details on completion, TABLE, and
PREDICATE."  However, since PREDICATE is used by all-completions as
well as try-completion during an invocation of completing-read, it
should be mentioned as well.

       Otherwise, the programmer has no way of figuring out what the
third argument passed into PREDICATE is -- the programmer needs to
know that if the third argument is nil, a single string (or nil or
t) should be returned, but if it's t, a list of possible completions
should be returned (try-completion passes in nil, while
all-completions passes in t, according to their documentation
strings).

	Here's a ChangeLog entry and a fix:

Thu Aug 11 20:27:02 1994  Jonathan I. Kamens  (jik@gza-client1)

	* minibuf.c (completing-read): mention `all-completions' in
	doc string.

*** minibuf.c	1994/08/11 20:26:20	1.1.1.1
--- minibuf.c	1994/08/11 20:26:39
***************
*** 933,939 ****
  PROMPT is a string to prompt with; normally it ends in a colon and a space.\n\
  TABLE is an alist whose elements' cars are strings, or an obarray.\n\
  PREDICATE limits completion to a subset of TABLE.\n\
! See `try-completion' for more details on completion, TABLE, and PREDICATE.\n\
  If REQUIRE-MATCH is non-nil, the user is not allowed to exit unless\n\
   the input is (or completes to) an element of TABLE.\n\
   If it is also not t, Return does not exit if it does non-null completion.\n\
--- 933,940 ----
  PROMPT is a string to prompt with; normally it ends in a colon and a space.\n\
  TABLE is an alist whose elements' cars are strings, or an obarray.\n\
  PREDICATE limits completion to a subset of TABLE.\n\
! See `try-completion' and `all-completions' for more details on completion,\n\
!  TABLE, and PREDICATE.\n\
  If REQUIRE-MATCH is non-nil, the user is not allowed to exit unless\n\
   the input is (or completes to) an element of TABLE.\n\
   If it is also not t, Return does not exit if it does non-null completion.\n\
Technical Details
Message-ID: <199408121849.OAA13202@gza-client1.aktis.com>
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!primenet!netnews.asu.edu !asuvax!cs.utexas.edu!math.ohio-state.edu!pacific.mps.ohio-state.edu!cis.ohio-state.edu!cam.ov.COM!jik

Show Full Headers
Complete Article Headers
X-Google-Language: ENGLISH,ASCII-7-bit
X-Google-Thread: fb2f1,4713fc66e076ac7b,start
X-Google-Attributes: gidfb2f1,public
X-Google-ArrivalTime: 1994-08-13 06:24:36 PST
Path: arc1-ca.pugleaf.net!bga.com!news.sprintlink.net!primenet!netnews.asu.edu      !asuvax!cs.utexas.edu!math.ohio-state.edu!pacific.mps.ohio-state.edu!cis.ohio-state.edu!cam.ov.COM!jik
From: jik@cam.ov.COM (Jonathan I. Kamens)
Newsgroups: gnu.emacs.bug
Subject: completing-read doc string mentions try-completion bug not all-completions
Date: 12 Aug 1994 23:26:33 -0400
Organization: GNUs Not Usenet
Lines: 44
Sender: daemon@cis.ohio-state.edu
Approved: bug-gnu-emacs@prep.ai.mit.edu
Distribution: gnu
Message-ID: <199408121849.OAA13202@gza-client1.aktis.com>