🚀 go-pugleaf

In GNU Emacs 19.25.2 of Fri Aug 12 1994 on gza-client1 (sparc-sun-sunos4.1.3)

A bug report submitted by someone locally:

>Highlighted headers are unreadable on my black and white display, so I
>tried to disable them.
>
>1) I set rmail-highlighted-headers to nil and got "Wrong argument
>type: stringp, nil" or somesuch when I read mail.
>
>2) I set rmail-highlighted-headers to "" and emacs entered an
>apparently infinite loop when I read mail.  When I C-g'ed the loop,
>the entire message header was highlighted.
>
>So I set it to "DO NOT HIGHLIGHT ANY FUCKING HEADERS" and it solved
>the problem, but somehow I don't think this should be necessary.

I fixed this by making rmail-highlight-headers not highlight when the
variable is nil.  ChangeLog entries and patches:

Sun Aug 14 03:24:15 1994  Jonathan I. Kamens  (jik@gza-client1)

	* loaddefs.el (rmail-highlighted-headers):
	Update doc string to indicate behavior
	when variable is nil.

	* rmail.el (rmail-highlight-headers): Don't highlight any if
	rmail-highlighted-headers is nil.

*** rmail.el	1994/08/11 19:52:39	1.7
--- rmail.el	1994/08/12 21:13:15
***************
*** 73,79 ****
  
  ;;;###autoload
  (defvar rmail-highlighted-headers "^From:\\|^Subject:" "\
! *Regexp to match Header fields that rmail should normally highlight.")
  
  ;;;###autoload
  (defvar rmail-delete-after-output nil "\
--- 73,80 ----
  
  ;;;###autoload
  (defvar rmail-highlighted-headers "^From:\\|^Subject:" "\
! *Regexp to match Header fields that rmail should normally highlight,
! or nil to not highlight any headers.")
  
  ;;;###autoload
  (defvar rmail-delete-after-output nil "\
***************
*** 1405,1411 ****
  ;; Find all occurrences of certain fields, and highlight them.
  (defun rmail-highlight-headers ()
    ;; Do this only if the system supports faces.
!   (if (fboundp 'internal-find-face)
        (save-excursion
  	(search-forward "\n\n" nil 'move)
  	(save-restriction
--- 1406,1412 ----
  ;; Find all occurrences of certain fields, and highlight them.
  (defun rmail-highlight-headers ()
    ;; Do this only if the system supports faces.
!   (if (and rmail-highlighted-headers (fboundp 'internal-find-face))
        (save-excursion
  	(search-forward "\n\n" nil 'move)
  	(save-restriction
*** loaddefs.el	1994/08/12 16:52:03	1.2
--- loaddefs.el	1994/08/12 21:13:58
***************
*** 4700,4706 ****
  *Regexp to match Header fields that rmail should normally hide.")
  
  (defvar rmail-highlighted-headers "^From:\\|^Subject:" "\
! *Regexp to match Header fields that rmail should normally highlight.")
  
  (defvar rmail-delete-after-output nil "\
  *Non-nil means automatically delete a message that is copied to a file.")
--- 4700,4707 ----
  *Regexp to match Header fields that rmail should normally hide.")
  
  (defvar rmail-highlighted-headers "^From:\\|^Subject:" "\
! *Regexp to match Header fields that rmail should normally highlight,
! or nil to not highlight any headers.")
  
  (defvar rmail-delete-after-output nil "\
  *Non-nil means automatically delete a message that is copied to a file.")